[BUGFIX:BP:11.5] Do not index missing fields #3372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the data used for a Solr field is not present in the data (e.g. if it is conditionally set via a custom indexer), the field will no longer be created. Previously the data was accessed anyways, resulting in a PHP warning which would abort the indexing in PHP 8. Now a check has been implemented to verify that the accessed variable actually exists in configuration and data. Fixes: TYPO3-Solr#3366
dkd-kaehm
approved these changes
Oct 20, 2022
dkd-kaehm
deleted the
bugfix/release-11.5.x/3366-do_not_index_missing_fields
branch
Closed
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 22, 2022
This is a maintenance release for TYPO3 11.5, containing: - [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335) - [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344) - [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341) - !!![TASK] Use preAddModifyDocuments hook for pages (TYPO3-Solr#3076) - [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361) - [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371) - [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372) - [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370) - [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373) - [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350) - [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396) - [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422) - [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425) - [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429) - [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428) - [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433) - [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434) - [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435) - [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392) - [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 22, 2022
This is a maintenance release for TYPO3 11.5, containing: - [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335) - [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344) - [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341) - !!![TASK] Use preAddModifyDocuments hook for pages (TYPO3-Solr#3076) - [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361) - [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371) - [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372) - [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370) - [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373) - [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350) - [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396) - [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422) - [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425) - [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429) - [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428) - [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433) - [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434) - [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435) - [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392) - [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
dkd-kaehm
added a commit
that referenced
this pull request
Dec 23, 2022
This is a maintenance release for TYPO3 11.5, containing: - [BUGFIX] Do not include removed strptime() (#3335) - [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (#3344) - [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (#3341) - !!![TASK] Use preAddModifyDocuments hook for pages (#3076) - [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (#3361) - [TASK:BP:11.5] Indexing configuration icon fallback (#3371) - [BUGFIX:BP:11.5] Do not index missing fields (#3372) - [TASK:BP:11.5] Introduce index queue type setting (#3370) - [TASK:BP:11.5] Do not index language with unconfigured core (#3373) - [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (#3350) - [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (#3396) - [TASK:BP:11.5] Introduce generic EXT:solr exception (#3422) - [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (#3425) - [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (#3429) - [TASK:Security] Update jQuery and its plugin libs (#3428) - [BUGFIX:P:11.5] Proper check for config.index_enable (#3433) - [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (#3434) - [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (#3435) - [FEATURE] Add signal before search in resultsAction (#3392) - [BUGFIX] Fix php warning undefined array key no_search_sub_entries (#3381) Please read the release notes: https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Backport 11.5
In case the data used for a Solr field is not present in the data (e.g. if it is conditionally set via a custom indexer), the field will no longer be created.
Previously the data was accessed anyways, resulting in a PHP warning which would abort the indexing in PHP 8.
Please add a testing instruction here
Fixes: #3366