Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix php warning undefined array key no_search_sub_entries #3381

Merged
merged 1 commit into from
Dec 22, 2022
Merged

[BUGFIX] Fix php warning undefined array key no_search_sub_entries #3381

merged 1 commit into from
Dec 22, 2022

Conversation

DrWh0286
Copy link
Contributor

To avoid php warning for undefined array key, check if key is set in $page array.

What this pr does

Fixing the follwing bug:

After enabling/disabling a page in page tree with the context menu the following php warning appears:

PHP Warning: Undefined array key "no_search_sub_entries" in /var/www/html/web/typo3conf/ext/solr/Classes/IndexQueue/RecordMonitor.php line 203

How to test

Steps to reproduce the behavior:

  1. Open context menu of a page in page tree
  2. Click on 'Disable' or 'Enable' (depends on state of the page ;-))
  3. The php warning appears

Fixes #3380

@DrWh0286
[BUGFIX] Fix php warning undefined array key no_search_sub_entries
aa6f3c3 
To avoid php warning for undefined array key, check if key is set in
$page array.

Fixes TYPO3-Solr#3380
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 22, 2022
@DrWh0286 @dkd-kaehm
[BUGFIX:P:12.0] Fix php warning undefined array key no_search_sub_ent…
345e0e9 
…ries

To avoid php warning for undefined array key, check if key is set in
$page array.

Fixes TYPO3-Solr#3380
Ports: TYPO3-Solr#3381
@dkd-kaehm dkd-kaehm mentioned this pull request Dec 22, 2022
Merged
dkd-kaehm pushed a commit that referenced this pull request Dec 22, 2022
@DrWh0286 @dkd-kaehm
[BUGFIX:P:12.0] Fix php warning undefined array key no_search_sub_ent…
eaac9e4 
…ries

To avoid php warning for undefined array key, check if key is set in
$page array.

Fixes #3380
Ports: #3381
@dkd-kaehm dkd-kaehm merged commit bb95516 into TYPO3-Solr:release-11.5.x Dec 22, 2022
@dkd-kaehm dkd-kaehm mentioned this pull request Dec 22, 2022
Closed
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 22, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
343c6cd 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (TYPO3-Solr#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372)
- [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429)
- [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435)
- [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-kaehm dkd-kaehm mentioned this pull request Dec 22, 2022
Merged
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this pull request Dec 22, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
76c75d4 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (TYPO3-Solr#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (TYPO3-Solr#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (TYPO3-Solr#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (TYPO3-Solr#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (TYPO3-Solr#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (TYPO3-Solr#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (TYPO3-Solr#3372)
- [TASK:BP:11.5] Introduce index queue type setting (TYPO3-Solr#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (TYPO3-Solr#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (TYPO3-Solr#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (TYPO3-Solr#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (TYPO3-Solr#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (TYPO3-Solr#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (TYPO3-Solr#3429)
- [TASK:Security] Update jQuery and its plugin libs (TYPO3-Solr#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (TYPO3-Solr#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (TYPO3-Solr#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (TYPO3-Solr#3435)
- [FEATURE] Add signal before search in resultsAction (TYPO3-Solr#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (TYPO3-Solr#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit that referenced this pull request Dec 23, 2022
@dkd-kaehm
[RELEASE] 11.5.1 - Maintenance Release
d095058 
This is a maintenance release for TYPO3 11.5, containing:

- [BUGFIX] Do not include removed strptime() (#3335)
- [BUGFIX:BP:11.5] Do not handle page updates on new page with uid 0 (#3344)
- [BUGFIX:BP:11.5] Shortcircuit work in SolrRoutingMiddleware (#3341)
- !!![TASK] Use preAddModifyDocuments  hook for pages (#3076)
- [BUGFIX] Fix array key access in ext_getSetup (Backport 11.5) (#3361)
- [TASK:BP:11.5] Indexing configuration icon fallback (#3371)
- [BUGFIX:BP:11.5] Do not index missing fields (#3372)
- [TASK:BP:11.5] Introduce index queue type setting (#3370)
- [TASK:BP:11.5] Do not index language with unconfigured core (#3373)
- [BUGFIX] Make API eID script compatible with TYPO3 v11.5 (#3350)
- [BUGFIX] Type-hinting for SiteUtility::getConnectionProperty() (#3396)
- [TASK:BP:11.5] Introduce generic EXT:solr exception (#3422)
- [BUGFIX:BP:11.5] Fix frontend Solr connection initialization (#3425)
- [ACTIONS:2022.12.22] Use fixed typo3/coding-standards 0.6.x < 0.7.0 for TYPO3 11.5 (#3429)
- [TASK:Security] Update jQuery and its plugin libs (#3428)
- [BUGFIX:P:11.5] Proper check for config.index_enable (#3433)
- [BUGFIX:P:11.5] Typecast $timestamp to int in TimestampToUtcIsoDate (#3434)
- [BUGFIX:P:11.5] prevent undefined array key warning if filter is empty (#3435)
- [FEATURE] Add signal before search in resultsAction (#3392)
- [BUGFIX] Fix php warning undefined array key no_search_sub_entries (#3381)

Please read the release notes:
https://github.com/TYPO3-Solr/ext-solr/releases/tag/11.5.1

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
  existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
  development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-kaehm dkd-kaehm mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrWh0286 @dkd-kaehm