-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add arm64-platform support (e.g. for Apple Silicon processors) to docker-image #3501
base: main
Are you sure you want to change the base?
[FEATURE] Add arm64-platform support (e.g. for Apple Silicon processors) to docker-image #3501
Conversation
@sjorek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjorek @brandung-sjorek
Thanks for your work, it looks really good.
@dkd-friedrich approved the patch as well.
We must make test on docker hub by some test account to avoid any troubles with current builds and setup of automated builds on Docker hub.
I'm currently a fully involved on TYPO3 12 compatibility task,
therefore we'll look and test it a little bit later.
@dkd-kaehm Good news, I'll keep my fingers crossed, while I'm still trying to pass the Let me know if I can be of any help. |
…rs) to docker-image This PR also updates all required actions in .github/workflow/ci.yml and adds a new publish-docker-hub job to the pipeline. Fixes: TYPO3-Solr#2891
786cf7f
to
6010303
Compare
363e234
to
a9bae2f
Compare
e865edc
to
89d9f0d
Compare
16bf8c5
to
dfcdd98
Compare
What this PR does
This PR adds arm64-platform support (e.g. for Apple Silicon processors) to
typo3solr/ext-solr
docker-image. Therefore several changes were neccessary:publish-docker-hub
job to the pipelinesolrci-image
image artifact from thetest
-job forlinux/amd64
(Intel & Co.) platformstypo3solr/ext-solr
image with the additionallinux/arm64
(Apple Silicon) platformpublish
-job topublish-typo3-ter
, to avoid confusion, with the newpublish-docker-hub
job.New GitHub Action environment-variables and secrets
How to test
Good question? I tried to test it with https://github.com/nektos/act#readme on Apple Silicon M2 Max and Mac OS Ventura 13.2.1. This brought me surprisingly far, but in the end I had no luck, as the
cibuild_docker.sh
always fails in theassertDataPathIsCreatedByApacheSolr
function. This is still confusing to me, as this does not seem to be related with this PR at all.Hope we can finish this (or another) solution together?
Cheers,
Stephan
As soon as everything ist running, this PR …
Fixes: #2891