Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic [TASK] Make EXT:solr TYPO3 12 LTS compatible #3376

Closed
66 of 68 tasks
3l73 opened this issue Oct 24, 2022 · 1 comment · Fixed by #3377
Closed
66 of 68 tasks

Epic [TASK] Make EXT:solr TYPO3 12 LTS compatible #3376

3l73 opened this issue Oct 24, 2022 · 1 comment · Fixed by #3377

Comments

@3l73
Copy link
Collaborator

3l73 commented Oct 24, 2022

This task contains all the sub task to get EXT:solr woking within TYPO3 12 LTS:
Note: The compatibility to TYPO3 11 LTS MUST NOT be assured.

Must have

Deprecations

Tasks after merge TYPO3 12 compatibility into main (Pull-Request: #3377)

Nice to have

Final 12.0.0


Current state of TYPO3 12 LTS support

2023.03.24

The indexing stack almost working now with following restriction:

  • TypoScrip templates on subpages are not loaded, but only from the root page is used. This will be fixed near alpha state.

Next steps:

  • Fix the search context
  • Fix small issues in BE-Modules

N/A

@3l73 3l73 added the 12LTS label Oct 24, 2022
@dkd-kaehm dkd-kaehm pinned this issue Oct 24, 2022
3l73 added a commit that referenced this issue Oct 24, 2022
Increase dependencies of TYPO3 to 12.0.0.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 24, 2022
Increase version of Solarium to 6.2.7 due dependency to symfony/event-dispatcher-contracts.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 24, 2022
Set requirement to dev-main

Resolves: #3376
3l73 added a commit that referenced this issue Oct 24, 2022
Adjust method signature and implement new method 'getLabel()'.

Use new class ContextualFeedbackSeverity as status code.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Increase version of Solarium to 6.2.7 due to dependency to symfony/event-dispatcher-contracts.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Set requirement to dev-main

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Adjust method signature and implement new method 'getLabel()'.

Use new class ContextualFeedbackSeverity as status code.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Configure PHP 8.1 and TYPO3 12.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Migrate the registration of status classes.

Resolves: #3376
3l73 added a commit that referenced this issue Oct 25, 2022
Remove inheritance to the TYPO3 translation ViewHelper.

Resolves: #3376
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 28, 2022
…anch

The GitHub Actions must run if pull-request against task/3376-TYPO3_12_compatibility is created.

Note:
The task/3376-TYPO3_12_compatibility must be used for pull-request against main branch.
The task/3376-TYPO3_12_compatibility must be used for non-stable pre-releases for TYPO3 12

Fixes: TYPO3-Solr#3382
Relates:  TYPO3-Solr#3376
dkd-kaehm added a commit that referenced this issue Oct 28, 2022
…anch

The GitHub Actions must run if pull-request against task/3376-TYPO3_12_compatibility is created.

Note:
The task/3376-TYPO3_12_compatibility must be used for pull-request against main branch.
The task/3376-TYPO3_12_compatibility must be used for non-stable pre-releases for TYPO3 12

Fixes: #3382
Relates:  #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Increase dependencies of TYPO3 to 12.0.0.

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Increase version of Solarium to 6.2.7 due to dependency to symfony/event-dispatcher-contracts.

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Set requirement to dev-main

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Adjust method signature and implement new method 'getLabel()'.

Use new class ContextualFeedbackSeverity as status code.

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Configure PHP 8.1 and TYPO3 12.

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Migrate the registration of status classes.

Resolves: #3376
dkd-kaehm pushed a commit that referenced this issue Oct 28, 2022
Remove inheritance to the TYPO3 translation ViewHelper.

Resolves: #3376
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 28, 2022
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 28, 2022
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue May 31, 2023
…ontext

EXT:solr does not want really the initialized TSFE object on multiple places at all. The TSFE object was necessary in EXT:solr versions, which used the TypoScript conditions for configure/map the Apache Solr cores to appropriated TYPO3 languages.  The indexing stack required this approach as well to be able to index  different pages and/or its records in single PHP-Process.

Nova-days this all hacks not required on TYPO3 12+ LTS anymore,  so the whole TSFE-Fake initialization stack will be removed and  "isolated TYPO3 Application" approach will be used. This will lead to more isolated and less exceptional behavior on TYPO3 components on EXT:solr side/feature set.

Relates: TYPO3-Solr#3376
Replaces: TYPO3-Solr#3582
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 1, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 1, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 1, 2023
dkd-kaehm pushed a commit that referenced this issue Jun 2, 2023
This change adds more information to the phpunit
xml files so the calls to phpunit can be simplified.

Relates: #3376
dkd-kaehm pushed a commit that referenced this issue Jun 2, 2023
This change adds new PSR-14 events:

* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforePageDocumentIsProcessedForIndexingEvent`
previously used with `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageAddDocuments']`

* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeDocumentIsProcessedForIndexingEvent`
previously used with `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueueIndexer']['preAddModifyDocuments']`

* `ApacheSolrForTypo3\Solr\Event\Indexing\BeforeDocumentsAreIndexedEvent`
previously used with `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueueIndexer']['indexItemAddDocuments']`

This way, EXT:solr migrates to PSR-14 events and adds a more defined way to utilize the PHP API and to help extension authors to understand what is used in EXT:solr.

The hooks
* `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueueIndexer']['preAddModifyDocuments']`
* `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueueIndexer']['indexItemAddDocuments']`
* `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageAddDocuments']`

are now removed in favor of the new events.

These interfaces related to the hooks are removed:
* `ApacheSolrForTypo3\Solr\IndexQueue\PageIndexerDocumentsModifier`
* `ApacheSolrForTypo3\Solr\IndexQueue\AdditionalIndexQueueItemIndexer`
* `ApacheSolrForTypo3\Solr\AdditionalPageIndexer`

Documentation is added, tests are adapted.

Relates: #3376, #3441
Fixes: #3437
dkd-kaehm pushed a commit that referenced this issue Jun 2, 2023
* Removes last fragments of csh usage
* Removes CSH registration from ext_tables.php
* Removes unused imports from ext_tables.php

Fixes: #3488
Relates: #3376
dkd-kaehm pushed a commit that referenced this issue Jun 2, 2023
…Documents"

* Uses ModuleProvider to check access to modules
* Removes unused imports
* Uses `f:be.link` for re-queue action in solr info module

Fixes: #3580
Relates: #3376
sfroemkenjw added a commit to sfroemkenjw/ext-solr that referenced this issue Jun 2, 2023
* Removes last fragments of csh usage
* Removes CSH registration from ext_tables.php
* Removes unused imports from ext_tables.php

Fixes: TYPO3-Solr#3488
Relates: TYPO3-Solr#3376
sfroemkenjw added a commit to sfroemkenjw/ext-solr that referenced this issue Jun 2, 2023
…Documents"

* Uses ModuleProvider to check access to modules
* Removes unused imports
* Uses `f:be.link` for re-queue action in solr info module

Fixes: TYPO3-Solr#3580
Relates: TYPO3-Solr#3376
dkd-kaehm pushed a commit that referenced this issue Jun 5, 2023
This change cleans up a few parts within the FrontendHelper
logic when indexing a page in the frontend:

- The PageIndexerInitialization and PageIndexerFinisher middleware
  are now merged.

- The PageIndexerRequestHandler contains no state

- The PageIndexerRequest is added to the PSR-7 Request as attribute
  "solr.pageIndexingInstructions" so it
  can be retrieved in various places.

- The AbstractFrontendHelper is removed, as the FrontendHelper
  middleware is thinned out. Activation and Deactivation rather
  works as initialization and flushing

This allows us to use DI in various places we hadn't had a chance
before.

In addition, the AuthorizationService getGroupsFE is removed
as it has been already replaced by a PSR-14 event.

AuthorizationService is now registered at any time
and now listens properly to the request object.

Relates: #3376
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 13, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 13, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 13, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Jun 13, 2023
dkd-kaehm added a commit that referenced this issue Jun 14, 2023
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 13, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task TYPO3-Solr#3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 13, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task TYPO3-Solr#3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 16, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task TYPO3-Solr#3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 16, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task TYPO3-Solr#3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit to dkd-kaehm/ext-solr that referenced this issue Oct 16, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task TYPO3-Solr#3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
dkd-kaehm added a commit that referenced this issue Oct 16, 2023
We are happy to release EXT:solr 12.0.0 for TYPO3 12 LTS.
The focus of this release has been on TYPO3 12 LTS compatibility.
NOTE: At least TYPO3 v12.4.3 is required.

Huge improvements:

* TYPO3 12 LTS compatibility
* Move to PSRs (Events, Middlewares, etc.)
* Integration PHPStan and many other testing improvements
* etc. and many more from epic task #3376

Please read the release notes:
* https://docs.typo3.org/p/apache-solr-for-typo3/solr/12.0/en-us/Releases/solr-release-12-0.html
* https://github.com/TYPO3-Solr/ext-solr/releases/tag/12.0.0

---

How to Get Involved

There are many ways to get involved with Apache Solr for TYPO3:

* Submit bug reports and feature requests on GitHub
* Ask or help or answer questions in our Slack channel
* Provide patches through pull requests or review and comment on
existing pull requests
* Go to www.typo3-solr.com or call dkd to sponsor the ongoing
development of Apache Solr for TYPO3

Support us by becoming an EB partner:
https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/

or call:
+49 (0)69 - 2475218 0
@dkd-kaehm
Copy link
Collaborator

Thanks to all contributors and EB partners, the stable release is tagged!

@dkd-kaehm dkd-kaehm unpinned this issue Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

2 participants