-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Introduce TYPO3_SOLR_ENABLED_CORES docker env variable #3503
[FEATURE] Introduce TYPO3_SOLR_ENABLED_CORES docker env variable #3503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christophlehmann
Thanks for this nice feature.
Didn't know about docker-entrypoint-initdb.d/
possibility.
The script of solr-ddev-site overrideSolrUnixUidAndGidAndSetPermissions ()
{
if [[ -v SOLR_OVERRIDE_UID ]] && grep -E -q '^[0-9]+$' <<<"${SOLR_OVERRIDE_UID:-}"; then
usermod --non-unique --uid "$SOLR_OVERRIDE_UID" solr
fi
if [[ -v SOLR_OVERRIDE_GID ]] && grep -E -q '^[0-9]+$' <<<"${SOLR_OVERRIDE_GID:-}"; then
groupmod --non-unique --gid "$SOLR_OVERRIDE_GID" solr
fi
chown -R solr:solr /var/solr
}
overrideSolrUnixUidAndGidAndSetPermissions can be adapted and moved there as well. |
@christophlehmann In think the @dkd-kaehm Right? |
The scripts inside of Also not more than the Docker-Image tests could be enriched for this stuff. |
@dkd-kaehm Sorry, maybe I got you wrong. You want (as I suggested) @christophlehmann to implement a test in |
Yes, if possible it would be nice to cover it with test cases. PS: @brandung-sjorek I thought, your suggestion was for enabling this feature in image at all, not about test scenarios in build process. |
👍 great feature, thx! |
This adds a startup script which disables all unneeded cores. Usage: `docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr` This enables only the english and german core (core_en, core_de) during startup. If the env variable is not set, then all cores are enabled (= default behaviour). The additional cores can be enabled afterwards by adding them to the TYPO3_SOLR_ENABLED_CORES env. variable. Fixes: TYPO3-Solr#3502
50ad20c
to
1dda542
Compare
This adds a startup script which disables all unneeded cores. Usage: `docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr` This enables only the english and german core (core_en, core_de) during startup. If the env variable is not set, then all cores are enabled (= default behaviour). The additional cores can be enabled afterwards by adding them to the TYPO3_SOLR_ENABLED_CORES env. variable. Ports: TYPO3-Solr#3503
This adds a startup script which disables all unneeded cores. Usage: `docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr` This enables only the english and german core (core_en, core_de) during startup. If the env variable is not set, then all cores are enabled (= default behaviour). The additional cores can be enabled afterwards by adding them to the TYPO3_SOLR_ENABLED_CORES env. variable. Ports: #3503
This adds a startup script which disables all unneeded cores. Usage: `docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr` This enables only the english and german core (core_en, core_de) during startup. If the env variable is not set, then all cores are enabled (= default behaviour). The additional cores can be enabled afterwards by adding them to the TYPO3_SOLR_ENABLED_CORES env. variable. Ports: TYPO3-Solr#3503
This adds a startup script which disables all unneeded cores. Usage: `docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr` This enables only the english and german core (core_en, core_de) during startup. If the env variable is not set, then all cores are enabled (= default behaviour). The additional cores can be enabled afterwards by adding them to the TYPO3_SOLR_ENABLED_CORES env. variable. Ports: TYPO3-Solr#3503
This adds a startup script which disables all unneeded cores.
Usage:
docker run -e 'TYPO3_SOLR_ENABLED_CORES=english german' -it typo3solr/ext-solr
This enables only the english and german core (core_en, core_de) during startup.
If the env variable is not set, then all cores are enabled (= default behaviour).
Resolves: #3502
Maintainers comments: