Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Skip further processing if no site found #3596

Closed
wants to merge 1 commit into from

Conversation

ochorocho
Copy link

If no site is found (e.g. due to missing configuration) skip the rest of the code.

Fixes: #3407

What this pr does

Skip processing if site is not found.

How to test

Please add a testing instruction here

How to test

Given, you have a global storage page (with a site configured, but solr disabled) to store records.

If no site is found (e.g. due to missing configuration) skip
the rest of the code.

Fixes: TYPO3-Solr#3407
@dkd-kaehm
Copy link
Collaborator

Rebased to the newest main state and fixed CS issue by removing spaces on blank line.

Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
but backports wanted:

  • release-11.5.x
  • release-11.2.x(ELTS?)
  • release-11.0.x(ELTS?)

@dkd-kaehm dkd-kaehm added the BACKPORTABLE The changes SHOULD be backported label Apr 12, 2023
@dkd-kaehm
Copy link
Collaborator

See:
#3598 (review)

@dkd-kaehm dkd-kaehm closed this Apr 12, 2023
christophlehmann added a commit to christophlehmann/ext-solr that referenced this pull request Apr 13, 2023
dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Apr 14, 2023
dkd-friedrich pushed a commit that referenced this pull request Apr 14, 2023
dkd-friedrich pushed a commit that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BACKPORTABLE The changes SHOULD be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Solr configuration not found because the root page is not configured
2 participants