Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Avoid getSolrConfiguration() on null #3598

Merged
merged 1 commit into from
Apr 14, 2023
Merged

[BUGFIX] Avoid getSolrConfiguration() on null #3598

merged 1 commit into from
Apr 14, 2023

Conversation

christophlehmann
Copy link
Contributor

@christophlehmann christophlehmann commented Apr 12, 2023 •
edited by dkd-friedrich
Loading

Fixes: #3597

Maintainers comment:

Ports:

  • release-11.5.x
  • [ ] release-11.2.x(ELTS?) not using the Site object
  • [ ] release-11.0.x(ELTS?) not using the Site object

dkd-kaehm
dkd-kaehm approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a coincidence!
Just one PR before yours: See #3596

But that with initialization of $siteRepository outside the loop wins the 🥇

Please add to the commits body:

Closes: #3596
Fixes: #3407, #3597

@dkd-kaehm dkd-kaehm added the BACKPORTABLE The changes SHOULD be backported label Apr 12, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Apr 12, 2023
Closed
dkd-friedrich pushed a commit to dkd-friedrich/ext-solr that referenced this pull request Apr 14, 2023
@christophlehmann @dkd-friedrich
[BUGFIX:BP:11.5] Avoid getSolrConfiguration() on null
c566c8e 
Ports: TYPO3-Solr#3598
Closes: TYPO3-Solr#3596
Fixes: TYPO3-Solr#3407, TYPO3-Solr#3597
@dkd-friedrich dkd-friedrich mentioned this pull request Apr 14, 2023
Merged
@dkd-friedrich
Copy link
Member

I've prepared a backport to 11.5

11.0 and 11.2 are not yet using the Site to retrieve the TypoScript configuration, so I'm skipping further backports.

dkd-friedrich pushed a commit that referenced this pull request Apr 14, 2023
@christophlehmann @dkd-friedrich
[BUGFIX:BP:11.5] Avoid getSolrConfiguration() on null
fbafb7d 
Ports: #3598
Closes: #3596
Fixes: #3407, #3597
@dkd-friedrich dkd-friedrich merged commit c1ba9c8 into TYPO3-Solr:main Apr 14, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
Closed
1 task
@christophlehmann christophlehmann deleted the patch-3 branch October 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm approved these changes

Assignees
No one assigned
Labels
BACKPORTABLE The changes SHOULD be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Call to a member function getSolrConfiguration() on null
3 participants
@christophlehmann @dkd-friedrich @dkd-kaehm