Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][FEATURE] Add new PSR-14 Event instead of SubstitutePageIndexer #3660

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

bmack
Copy link
Collaborator

@bmack bmack commented Jun 2, 2023

What this pr does

$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageSubstitutePageDocument'] is removed in favor of a new PSR-14 event:

ApacheSolrForTypo3\Solr\Event\Indexing\AfterPageDocumentIsCreatedForIndexingEvent

For this reason, the SubstitutePageIndexer Interface is removed.

At the same time, the Typo3PageIndexer class is now merged into FrontendHelper/PageIndexer to avoid cross-cutting concerns between classes and to show the dependencies to TSFE properly.

The documentation and upgrade guide is adapted.

Relates: #3437

$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageSubstitutePageDocument']
is removed in favor of a new PSR-14 event:

"ApacheSolrForTypo3\Solr\Event\Indexing\AfterPageDocumentIsCreatedForIndexingEvent"

For this reason, the SubstitutePageIndexer Interface is removed.

At the same time, the "Typo3PageIndexer" class is now merged
into FrontendHelper/PageIndexer to avoid cross-cutting conerns
between classes and to show the dependencies to TSFE properly.
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmack bmack changed the title [!!!][FEATURE] Add new PSR-14 instead of SubstitutePageIndexer [!!!][FEATURE] Add new PSR-14 Event instead of SubstitutePageIndexer Jun 2, 2023
@dkd-kaehm dkd-kaehm merged commit 1e23b41 into TYPO3-Solr:main Jun 2, 2023
@dkd-kaehm dkd-kaehm mentioned this pull request Oct 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants