Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Replace Signals with PSR-14 events #3437

Closed
1 task done
Tracked by #3376
dkd-kaehm opened this issue Dec 22, 2022 · 0 comments · Fixed by #3452 or #3651
Closed
1 task done
Tracked by #3376

[TASK] Replace Signals with PSR-14 events #3437

dkd-kaehm opened this issue Dec 22, 2022 · 0 comments · Fixed by #3452 or #3651
Assignees
@3l73
Labels
12LTS BACKPORTABLE The changes SHOULD be backported BREAKING CHANGE
Milestone
12.0 aka TYPO3 12...

Comments

@dkd-kaehm
Copy link
Collaborator

dkd-kaehm commented Dec 22, 2022 •
edited
Loading

What should be done in the scope of this task?

List of all Signals to replace with events:

  • beforeIndexItems

  • beforeIndexItem

  • afterIndexItem

  • afterIndexItems

  • resultsAction (in \ApacheSolrForTypo3\Solr\Controller\SearchController::resultsAction)

  • formAction (in \ApacheSolrForTypo3\Solr\Controller\SearchController::formAction)

  • frequentlySearchedAction (in \ApacheSolrForTypo3\Solr\Controller\SearchController::frequentlySearchedAction)

  • optionsParsed (in \ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options\OptionsFacetParser::parse)

  • added by [FEATURE] Add signal before search in SearchController::resultsAction #3387
This was referenced Dec 22, 2022
Open
Closed
@3l73 3l73 self-assigned this Jan 16, 2023
3l73 added a commit to 3l73/ext-solr that referenced this issue Jan 16, 2023
@3l73
!!![TASK] Replace signal-slot with event dispatcher
35e6bee 
The signal-slot technology was deprecated and now replaced threw the EventDispatcher.

Resolves: TYPO3-Solr#3437
@3l73 3l73 mentioned this issue Jan 16, 2023
Merged
@3l73 3l73 linked a pull request Jan 16, 2023 that will close this issue
[TASK:T12] Replace SignalSlot with EventDispatcher #3452
Merged
@3l73 3l73 added BACKPORTABLE The changes SHOULD be backported 12LTS BREAKING CHANGE labels Jan 16, 2023
@dkd-kaehm dkd-kaehm mentioned this issue Jun 2, 2023
Merged
This was referenced Jun 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3l73 3l73

Labels
12LTS BACKPORTABLE The changes SHOULD be backported BREAKING CHANGE
Projects
None yet
Milestone
12.0 aka TYPO3 12 LTS - major release
2 participants
@3l73 @dkd-kaehm