[!!!][TASK] Remove UriStrategy logic and move to PSR-14 event #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UriStrategy concept was needed to generate Frontend URLs in order to index a frontend page. This concept was used in TYPO3 v9 to support site-based routing and non-site-based projects. This has now been removed as TYPO3 Core v11+ does only support site-based frontend page resolving. For this reason, the "UriStrategyFactory" and all the handling has been removed, and the "TYPO3SiteStrategy" has been renamed to "PageUriBuilder". The hook logic to modify the indexing URL `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueuePageIndexer']['dataUrlModifier']` and the according interface "PageIndexerDataUrlModifier" has been removed and replaced by a new PSR-14 event: `ApacheSolrForTypo3\Solr\Event\Indexing\AfterFrontendPageUriForIndexingHasBeenGeneratedEvent". Usages of UriHelper have been reduced in favor of PSR-7 UriInterface. IntegrationTests for the new Event have been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
The UriStrategy concept was needed to generate Frontend URLs in order to index a frontend page.
This concept was used in TYPO3 v9 to support site-based routing and non-site-based projects.
This has now been removed as TYPO3 Core v11+ does only support site-based frontend page resolving.
For this reason, the "UriStrategyFactory" and all the handling has been removed, and the "TYPO3SiteStrategy" has been renamed to "PageUriBuilder".
The hook logic to modify the indexing URL
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['IndexQueuePageIndexer']['dataUrlModifier']and the according interface "PageIndexerDataUrlModifier" has been removed and replaced by a new PSR-14 event:ApacheSolrForTypo3\Solr\Event\Indexing\AfterFrontendPageUriForIndexingHasBeenGeneratedEvent".Usages of UriHelper have been reduced in favor of PSR-7 UriInterface.
IntegrationTests for the new Event have been added.
Relates: #3437