[!!!][FEATURE] Rework Search Component system #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Search Components have been reworked and the Component system have been moved to a PSR-14 Event `AfterSearchQueryHasBeenPreparedEvent`. This way, the registration works just as other PSR-14 events, and Dependency Injection is now used consistently across all Componenents. The Component System is now merged with the previous hook `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['modifySearchQuery']` and the `ApacheSolrForTypo3\Solr\Search\Modifier` interface. Two other hooks have been migrated as well. Tests who actually tested the registration have been removed, further existing tests have been adapted. Fixes: TYPO3-Solr#3675
dkd-kaehm
force-pushed
the
pr/search-events
branch
from
efd6f29 to
71fe543
Compare
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Search Components have been reworked and the Component system have been moved to a PSR-14 Event
AfterSearchQueryHasBeenPreparedEvent.This way, the registration works just as other PSR-14 events, and Dependency Injection is now used consistently across all Componenents.
The Component System is now merged with the previous hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['modifySearchQuery']and theApacheSolrForTypo3\Solr\Search\Modifierinterface.Two other hooks have been migrated as well.
Tests who actually tested the registration have been removed, further existing tests have been adapted.
Fixes: #3675