Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to illustrate a bug and fix it ;) #501

Merged
merged 6 commits into from
Nov 3, 2023

Conversation

Christian24
Copy link
Contributor

@Christian24 Christian24 commented Nov 2, 2023

This adds tests for #502 and closes #502.

Copy link

codesandbox-ci bot commented Nov 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Christian24 Christian24 marked this pull request as ready for review November 2, 2023 22:07
@Christian24 Christian24 changed the title Added tests to illustrate a bug Added tests to illustrate a bug and fix it ;) Nov 2, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/form-core/src/utils.ts 89.13% <ø> (ø)
packages/react-form/src/createFormFactory.ts 100.00% <100.00%> (ø)
packages/react-form/src/formContext.ts 83.33% <ø> (ø)
packages/react-form/src/useForm.tsx 89.47% <100.00%> (+0.58%) ⬆️
...ckages/react-form/src/useIsomorphicLayoutEffect.ts 100.00% <100.00%> (ø)
packages/solid-form/src/createFormFactory.ts 100.00% <100.00%> (ø)
packages/solid-form/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/yup-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/yup-form-adapter/src/validator.ts 100.00% <100.00%> (ø)
packages/zod-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
... and 7 more

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 25a2fc8 into TanStack:main Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmounting a field does not update the form
3 participants