Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: deprecate callbacks on useQuery #5407

Merged
merged 1 commit into from
May 13, 2023
Merged

docs: deprecate callbacks on useQuery #5407

merged 1 commit into from
May 13, 2023

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented May 13, 2023 •
edited
Loading

@vercel
Copy link

vercel bot commented May 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) May 13, 2023 1:56pm

@NMinhNguyen
Copy link
Contributor Author

NMinhNguyen commented May 13, 2023 •
edited
Loading

Wasn't sure if the commit should be feat or something else. Updated to docs because it's JSDoc 🤷‍♂️

@NMinhNguyen NMinhNguyen force-pushed the 05-13-feat_deprecate_callbacks_on_useQuery_ branch from 70c21cf to 2c66536 Compare May 13, 2023 13:56
@NMinhNguyen NMinhNguyen changed the title feat: deprecate callbacks on useQuery docs: deprecate callbacks on useQuery May 13, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@TkDodo TkDodo merged commit 5608a04 into TanStack:main May 13, 2023
@seiwonpark seiwonpark mentioned this pull request May 16, 2023
Merged
@NMinhNguyen NMinhNguyen deleted the 05-13-feat_deprecate_callbacks_on_useQuery_ branch May 20, 2023 14:33
@alicenstar
Copy link

@NMinhNguyen @TkDodo Can I ask what the reason for deprecating these callbacks is? And if they'll be replaced with something else/what you recommend using instead?

@NMinhNguyen
Copy link
Contributor Author

@NMinhNguyen @TkDodo Can I ask what the reason for deprecating these callbacks is? And if they'll be replaced with something else/what you recommend using instead?

This should hopefully answer your question: https://tkdodo.eu/blog/breaking-react-querys-api-on-purpose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NMinhNguyen @alicenstar @TkDodo