Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated docs #10

Merged
merged 8 commits into from
May 17, 2023
Merged

fix: updated docs #10

merged 8 commits into from
May 17, 2023

Conversation

seiwonpark
Copy link
Contributor

@seiwonpark seiwonpark commented May 16, 2023

(Updated - 리뷰 반영하였습니다.)

재미있는 기록을 하시고 계시는군요. 일부 간단한 수정을 진행했습니다.


Modified

  • 일부 오탈자를 수정하였습니다.
  • 코드 블럭의 가시화를 위해 기존의 jsdiff로 변경하였습니다.
  • staleTimecacheTime이 잘못 설정된 값을 수정하고, 가독성을 위해 ms 단위로 분리했습니다.

Added


Removed

  • ### 헤더의 경우, 목차 바로가기를 제거했습니다.

Copy link
Owner

@ssi02014 ssi02014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무도 좋은 내용으로 PR 감사드립니다 🙇🏻‍♂️
검토를 진행했고, 목차와 같은 큰 틀은 유지하고자 합니다~
제 의도와 싱크를 맞춰서 코멘트 남겼습니다
다시한번 좋은 PR 감사드립니다~

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
document/v4.md Show resolved Hide resolved
document/v4.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
document/v4.md Show resolved Hide resolved
Copy link
Owner

@ssi02014 ssi02014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무도 좋은 내용으로 PR 감사드립니다 🙇🏻‍♂️
검토를 진행했고, 목차와 같은 큰 틀은 유지하고자 합니다~
제 의도와 싱크를 맞춰서 코멘트 남겼습니다
다시한번 좋은 PR 감사드립니다~

@seiwonpark seiwonpark requested a review from ssi02014 May 17, 2023 08:00
@ssi02014 ssi02014 merged commit ab8ef8f into ssi02014:master May 17, 2023
@ssi02014
Copy link
Owner

기여 감사드립니다 🙇🏻‍♂️

@seiwonpark seiwonpark deleted the fix/update-docs branch May 17, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants