-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AndroidX Media compat in AudioReactor #5065
Use AndroidX Media compat in AudioReactor #5065
Conversation
you can update to 1.2.1 :) |
Edit: I updated it and the change is visible on the branch, but it's not updating on the PR? Is GitHub acting up or something? |
Ok there we go. That was weird 🤔 |
Now that I take a look at Gradle dependencies, I noticed that none of the AndroidX dependencies have entries in the licenses page. Is this intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you :-D
@Redirion could you also approve, if you think it's ok?
Could be replaced with:
|
@Redirion Completely missed that! Thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Stypox looks ready to merge
@Stypox Sorry for another mention, but idk if this was missed (repo activity looks mighty hectic right now). This should be all good to merge :) |
I would like to merge this, but due to the "2 vulnerabilities" it isn't possible. @theScrabi can you check why this is blocking? I don't have access to snyk. |
Some of the other PRs from around the time this one was made have also faced the same issue 🤔 |
That used to be the case earlier. Now you can see that it doesn't have the "Required" label, which Why it isn't either running or finished is a mystery. The Checks tab should show a job, and there are currently none. |
@opusforlife2 Do you think it would regenerate the checks if I repushed the commit? 🤔 I'll give it a try. |
It worked :) |
Yay! |
What is it?
Description of the changes in your PR
APK testing
app-debug-androidx-media-audioreactor.zip
Due diligence