-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use view binding in VideoPlayer. #5253
Use view binding in VideoPlayer. #5253
Conversation
515bcaa
to
064c965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it works, changes also look good, thank you :-D
Maybe you could rename playerBinding
into just binding
, so that there is less code to read. closeOverlayBinding
is ok though, since it's a specific binding.
playbackSeekBar = (SeekBar) binding.playbackSeekBar; | ||
qualityTextView = (TextView) binding.qualityTextView; | ||
playbackSpeed = (TextView) binding.playbackSpeed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you keep these three variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting compilation errors as those three views were being stored as View
variables for some reason.
I chose the name to keep the bindings distinguishable, but I'll rename the binding. |
064c965
to
a6db02f
Compare
a6db02f
to
f2ea8cc
Compare
f2ea8cc
to
fa75c79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and tested. This works. Thank you again :-D
Now I'll have to rebase #5371, wish me luck ;-)
What is it?
Description of the changes in your PR
VideoPlayer
andVideoPlayerImpl
.APK testing
debug.zip
Due diligence