-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Objects.requireNonNull(). #5254
Use Objects.requireNonNull(). #5254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changes look good.
I think it makes sense to have the null
checks at the beginning of a method to not execute code unnecessarily.
app/src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java
Outdated
Show resolved
Hide resolved
app/src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java
Outdated
Show resolved
Hide resolved
I'd also remove some strings which are |
@Stypox Sounds good |
bdd5058
to
5a30dcf
Compare
app/src/main/java/org/schabi/newpipe/about/LicenseFragment.java
Outdated
Show resolved
Hide resolved
5a30dcf
to
14a2171
Compare
What is it?
Description of the changes in your PR
Objects.requireNonNull()
to ensure null safety instead of throwingNullPointerException
s manually.APK testing
debug.zip
Due diligence