Fix urls with timestamps not being played #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
TobiGr
added
bug
Redirion
approved these changes
Dec 31, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
Caused by incorrect changes compared to 0.19.8 code. see
https://github.com/TeamNewPipe/NewPipe/blob/v0.19.8/app/src/main/java/org/schabi/newpipe/player/BasePlayer.java#L305-L327
it certainly can be written better, but i don't understand half of what that monstrosity of method does
example urls
Fixes the following issue(s)
APK testing
see CI
https://github.com/TeamNewPipe/NewPipe/actions/runs/453310328
Due diligence