Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Somali Readme #5383

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Created Somali Readme #5383

merged 3 commits into from
Jan 12, 2021

Conversation

nadiration
Copy link
Contributor

@nadiration nadiration commented Jan 10, 2021

Created README.so.md file

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Created Readme file for Somali

Due diligence

@triallax
Copy link
Contributor

Thanks for creating an PR! You usually shouldn't add new items to the "What is it?" section. In this case, you should remove your "read me translation" item and instead check "Meta improvement to the project (dev facing)" since this is not a user-facing change and isn't strictly related to code.

@triallax triallax added feature request Issue is related to a feature in the app localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code labels Jan 10, 2021
@nadiration
Copy link
Contributor Author

Thanks for creating an PR! You usually shouldn't add new items to the "What is it?" section. In this case, you should remove your "read me translation" item and instead check "Meta improvement to the project (dev facing)" since this is not a user-facing change and isn't strictly related to code.

Done

@TobiGr
Copy link
Member

TobiGr commented Jan 11, 2021

Thank you, please link this translations in the other two READMEs
https://github.com/TeamNewPipe/NewPipe/blob/dev/README.md
https://github.com/TeamNewPipe/NewPipe/blob/dev/README.ko.md

Copy link
Contributor Author

@nadiration nadiration left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If by linking you mean the link in 'Read this in another language' i already did that from the beginning. Now (third commit) i added the sign : next to the word "Warning:" (the one that warns about the beta version) which i forgot before.

@TobiGr
Copy link
Member

TobiGr commented Jan 11, 2021

What I meant was linking this translation in the other READMEs, so it can be found :)

@opusforlife2
Copy link
Collaborator

@nadiration You edit the other README files and add a link to the Somali README in them.

@nadiration
Copy link
Contributor Author

nadiration commented Jan 12, 2021

@TobiGr it's done now. I linked them and created PRs for them

Copy link
Member

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you don't need to open a PR for every file you edit. While editing the files, just make sure you are on the branch of your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app localisation / translation Everything that has to do with translations or Weblate meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants