-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout branch in CI process #5407
Conversation
Currently does not work because it is trying to fetch the branch from the NewPipe repo. But the branch exists on the repo of the PR opener, which usually is not NewPipe |
What about git branch ${VAR_FOR_BRANCH_NAME} |
that will throw an error if the branch already exists. which can occur if the PR comes from the newpipe repo itself or comes from the dev branch of another repo. I don't know if that aborts the run, but still not ideal |
This way the debug build app id contains the branch name again.
444dd39
to
4196891
Compare
Then what about deleting the branch if it exists and then doing git branch? |
@TobiGr @Stypox I went with see my updated pr body
I didn't want to figure out how to do that in shell script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks good to me!
What is it?
Description of the changes in your PR
github.head_ref & github.event_name
https://docs.github.com/en/free-pro-team@latest/actions/reference/context-and-expression-syntax-for-github-actions#github-contextgit checkout -B
https://git-scm.com/docs/git-checkout#Documentation/git-checkout.txt--BltnewbranchgtDue diligence