Combine the two Constants files into one file. #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stypox
reviewed
Jan 15, 2021
| /** | ||
| * Default duration when using throttle functions across the app, in milliseconds. | ||
| */ | ||
| const val DEFAULT_THROTTLE_TIMEOUT = 120L |
There was a problem hiding this comment.
I see there are no other file changes. Isn't this variable used anywhere? If that's the case remove it
There was a problem hiding this comment.
It's used in some of the ViewModels.
There was a problem hiding this comment.
Shouldn't the ViewModels imports also be changed? Otherwise they would point to ConstantsKt, wouldn't they?
There was a problem hiding this comment.
The ViewModels are written in Kotlin, so no change is needed.
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 20, 2021
…ify_constants Combine the two Constants files into one file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Constants.javaandConstantsKt.ktinto one file.APK testing
debug.zip
Due diligence