Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use view binding in VideoDetailFragment. #5438

Conversation

Isira-Seneviratne
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Make use of view binding in VideoDetailFragment.

Due diligence

Note: Android Studio may indicate that some of the binding fields are unavailable, but they are actually generated correctly in the binding class:

Screenshot 2021-01-17 100939
Screenshot 2021-01-17 101007

@XiangRongLin XiangRongLin added the codequality Improvements to the codebase to improve the code quality label Jan 17, 2021
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. I tested and everything works fine. Thank you!

@Stypox Stypox merged commit 6277639 into TeamNewPipe:dev Jan 17, 2021
@Isira-Seneviratne Isira-Seneviratne deleted the Use_view_binding_in_VideoDetailFragment branch January 18, 2021 00:35
This was referenced Jan 18, 2021
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 20, 2021
…e_view_binding_in_VideoDetailFragment

Use view binding in VideoDetailFragment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codequality Improvements to the codebase to improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants