Update to ExoPlayer 2.12.3

[Redirion]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

Updates ExoPlayer from 2.11 to 2.13

Note that we will have to do another PR to migrate from deprecated mediasession to media2.
However this will most likely require to also rework everything to the new MediaItems instead of working with MediaSources.
For now however this can stay and if ExoPlayer stays being compatible with mediasession we aren't in a rush.

Due diligence

• I read the contribution guidelines.

[TacoTheDank]

@Redirion Also, I think media2 only supports API 21 and newer, so that would require dropping KitKat support, which will definitely cut off a small chunk of users 🤔

[Stypox]

@TacoTheDank we will be forced to drop KitKat support sooner or later anyway due to OkHttp 3.12.x being discontinued on December 31, 2021

[TacoTheDank]

@Stypox All okay with me lol, though I do feel kinda bad for those older phone users. The only option they really have left now is SkyTube or using a mobile browser. (Also, you should edit your comment to specify the 3.12.x LTS branch, because you scared me with "OkHttp being discontinued" 😰)

[Redirion]

@TacoTheDank do you have a source for the API 21 requirement of media2 for me? I wasn't able to find that info.

[TacoTheDank]

@Redirion I got that idea from the answer here: https://stackoverflow.com/questions/57566102/what-are-the-differences-between-mediasessioncompat-and-mediasession-in-android

Perhaps I misunderstood it 🤔

[Redirion]

found something. According to this website media2 in the current version that is used by ExoPlayer requires API 16: https://androidx.tech/artifacts/media2/media2-session/1.1.0

while the media2 extension of ExoPlayer declares API 19: https://github.com/google/ExoPlayer/blob/release-v2/extensions/media2/build.gradle (this could however be overwritten by our gradle config, if ExoPlayer raises this to 21, as long as media2 stays below 21).

[TacoTheDank]

@Redirion I see... 🤔

Oh btw, ExoPlayer 2.12.0 introduced two convenience methods play() and pause(), which are equivalent to setPlayWhenReady(true) and setPlayWhenReady(false), respectively. There are two usages of setPlayWhenReady in https://github.com/TeamNewPipe/NewPipe/blob/dev/app/src/main/java/org/schabi/newpipe/player/helper/AudioReactor.java that could be replaced with the convenience methods. (Here's the link in ExoPlayer's release notes)

[Stypox]

The only option they really have left now is SkyTube or using a mobile browser

@TacoTheDank they would still be able to use NewPipe legacy

[opusforlife2]

@Stypox Does Newpipe Legacy not use OkHttp?

[Stypox]

It does, but I think it can be kept or replaced with something else specific to old android versions

[TacoTheDank]

The only option they really have left now is SkyTube or using a mobile browser

@TacoTheDank they would still be able to use NewPipe legacy

Oh yeah, and that :)

[TacoTheDank]

Is this good to merge?

[Redirion]

@Stypox I am a bit hesitant to merge my own PR. From my opinion I would say this is good to merge. Or would you prefer if we skip ExoPlayer 2.12 and move directly to 2.13?

[Stypox]

I added a commit with a few style improvements and fixes of warnings. I tested playing some videos and enabling skip silence and everything worked as expected

[Redirion]

Now we seem to have the situation, that we require a third dev to approve this PR as we both contribute to it

[opusforlife2]

You could always approve each other's changes. :P

[opusforlife2]

@Redirion Were you ever invited to join the Newpipe channel on IRC? If not, could you please make a Matrix account and join it?

[Redirion]

You could always approve each other's changes. :P

I just tried but I may not approve my own pull request even though the last commit was not by me

[Stypox]

I tested again and everything works fine. Thanks :-)

[opusforlife2]

Were you ever invited to join the Newpipe channel on IRC? If not, could you please make a Matrix account and join it?

@Redirion