Fix minimize on app switch always opens popup #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
TobiGr
approved these changes
Jan 28, 2021
| @@ -3822,11 +3823,14 @@ private void onFragmentStopped() { | |||
| switch (getMinimizeOnExitAction(context)) { | |||
| case MINIMIZE_ON_EXIT_MODE_BACKGROUND: | |||
| useVideoSource(false); | |||
| break; | |||
XiangRongLin
approved these changes
Jan 28, 2021
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 21, 2021
Fix minimize on app switch always opens popup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
break;s were missing from a switch statement 🤦♂️While I was at it I also fixed some warnings and did other consistency improvements.
Fixes the following issue(s)
Fixes the comment #5455 (comment)
Due diligence