Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open in browser option to long-press menu #6280

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Add Open in browser option to long-press menu #6280

merged 2 commits into from
Jun 3, 2021

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented May 13, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR adds the Open in browser option to long-press menu when long pressing a stream and a subscription.

Screenshots:

  • Long pressing a subscription:
    Open in browser subscription long-press

  • Long pressing a stream:
    Open in browser stream long-press

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@AudricV AudricV added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels May 13, 2021
@AudricV

This comment has been minimized.

@AudricV
Copy link
Member Author

AudricV commented May 13, 2021

What position of the Open in browser command do you prefer?

  • After the Share command (actual behavior) (react with thumbs up if you want this):

    Open in browser after Share

  • Before the Share command (react with thumbs down if you want this):

    Open in browser before Share

@AudricV

This comment has been minimized.

Add Open in browser option to long-press menu when long pressing a stream and a subscription
@TobiGr TobiGr merged commit f739ed7 into TeamNewPipe:dev Jun 3, 2021
@AudricV AudricV deleted the open-in-browser-long-press-menu branch June 3, 2021 12:14
This was referenced Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants