Release 0.21.4 #6432
Merged
Release 0.21.4 #6432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EmptyFragment should not have a constructor at all. Now a static methods creates the Fragment and arguments are handled via a Bundle.
- Remove multiple casts of obj - Simply use object equals on the streams because PlayQueueItem’s equals already compares urls
Assignments that don't require the constructor can be moved out.
Original did not cover the case of when streams is empty and documentation does not specify any input restrictions. There's an ambiguity with broadcasting an event between the documentation and the actual code (see TODO).
PlayQueueItem overrides equals and hashCode, so using indexOf is perfectly fine.
Final fields should be arranged first
Stops Android Studio from "recognizing" them as tests
- Add early return for invalid sizes to shuffle - Rename variables to be more descriptive - Refactor moving list element, removing unnecessary operations - Unwrap if clause for adding to history because the condition is guaranteed by the guard clause - Inline the value 0 for the ReorderEvent - Update documentation to reflect new changes
After testing the app, I realized that shuffling a queue with size 2 does nothing
Does not affect Gradle tests and only benefits IDE workflow
Co-authored-by: yashpalgoyal1304 <yashpalgoyal1304@gmail.com>
Use AdoptOpenJDK instead of Zulu in GitHub actions
Test and clean up PlayQueue
Fix and improve setting import and export paths
[YouTube] Fix broken likes in comments
Fix playback speed not being updated in PlayQueueAcitvity
Fix Play with Kodi button in Player always prompts to install Kore
Currently translated at 56.0% (28 of 50 strings) Translated using Weblate (Russian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (German) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Interlingua) Currently translated at 40.0% (263 of 657 strings) Translated using Weblate (Chinese (Traditional)) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Slovak) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Dutch) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Hebrew) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Arabic) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Greek) Currently translated at 99.8% (656 of 657 strings) Translated using Weblate (Italian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Russian) Currently translated at 98.9% (650 of 657 strings) Translated using Weblate (French) Currently translated at 99.8% (656 of 657 strings) Translated using Weblate (German) Currently translated at 98.9% (650 of 657 strings) Translated using Weblate (English) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Interlingua) Currently translated at 34.6% (222 of 641 strings) Translated using Weblate (Serbian) Currently translated at 100.0% (641 of 641 strings) Translated using Weblate (Serbian) Currently translated at 16.0% (8 of 50 strings) Translated using Weblate (Odia) Currently translated at 4.2% (27 of 641 strings) Translated using Weblate (Odia) Currently translated at 2.0% (1 of 50 strings) Translated using Weblate (Dutch (Belgium)) Currently translated at 99.3% (637 of 641 strings) Translated using Weblate (Swedish) Currently translated at 87.3% (560 of 641 strings) Translated using Weblate (Serbian) Currently translated at 100.0% (641 of 641 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (641 of 641 strings) Translated using Weblate (Greek) Currently translated at 100.0% (641 of 641 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (50 of 50 strings) Translated using Weblate (French) Currently translated at 70.0% (35 of 50 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (50 of 50 strings) Translated using Weblate (Ukrainian) Currently translated at 8.0% (4 of 50 strings) Translated using Weblate (Lithuanian) Currently translated at 4.0% (2 of 50 strings) Translated using Weblate (Bengali) Currently translated at 93.7% (601 of 641 strings) Translated using Weblate (Interlingua) Currently translated at 34.3% (220 of 641 strings) Translated using Weblate (Ukrainian) Currently translated at 8.0% (4 of 50 strings) Co-authored-by: Andrij Mizyk <andmizyk@gmail.com> Co-authored-by: David Braz <davidbrazps2@gmail.com> Co-authored-by: Eric <spice2wolf@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Hritik R <hpujhari7@gmail.com> Co-authored-by: JY3 <GeeyunJY3@gmail.com> Co-authored-by: Jacque Fresco <aidter@use.startmail.com> Co-authored-by: Jeff Huang <s8321414@gmail.com> Co-authored-by: Juraj Timko <timko@netrix.sk> Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com> Co-authored-by: Ldm Public <ldmpub@gmail.com> Co-authored-by: Louis Morel <louismorel03@outlook.fr> Co-authored-by: Oymate <dhruboadittya96@gmail.com> Co-authored-by: Rex_sa <rex.sa@pm.me> Co-authored-by: S3aBreeze <paperwork@evilcorp.ltd> Co-authored-by: Software In Interlingua <softinterlingua@gmail.com> Co-authored-by: Terry Louwers <t.louwers@gmail.com> Co-authored-by: TobiGr <tobigr@mail.de> Co-authored-by: Vasilis K <skyhirules@gmail.com> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: Zhiheng Xu <xeric.2002@gmail.com> Co-authored-by: bomzhellino <adm.bomzh@gmail.com> Co-authored-by: chr56 <chr0056@gmail.com> Co-authored-by: gymka <gymka@archlinux.lt> Co-authored-by: jul-debug <jul333666@gmail.com> Co-authored-by: nautilusx <translate@disroot.org> Co-authored-by: random r <epsilin@yopmail.com> Co-authored-by: whenwesober <naomi16i_1298q@cikuh.com> Co-authored-by: Обилић <mudo2233@tutanota.com> Co-authored-by: Слободан Симић(Slobodan Simić) <slsimic@gmail.com> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lt/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/or/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sr/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata
Localization updates and small code improvements
This is a fix for the release PRs
Closed
Fixed typo
Some translations come with longer words causing them to wrap at strange positions
Hide queue duration when displaying segment panel
Currently translated at 100.0% (51 of 51 strings) Translated using Weblate (German) Currently translated at 56.8% (29 of 51 strings) Translated using Weblate (Polish) Currently translated at 99.6% (655 of 657 strings) Translated using Weblate (Italian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (French) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (German) Currently translated at 56.8% (29 of 51 strings) Translated using Weblate (Sardinian) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (51 of 51 strings) Translated using Weblate (Interlingua) Currently translated at 40.1% (264 of 657 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (657 of 657 strings) Translated using Weblate (French) Currently translated at 99.8% (656 of 657 strings) Translated using Weblate (German) Currently translated at 100.0% (657 of 657 strings) Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it> Co-authored-by: Eric <spice2wolf@gmail.com> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: J. Lavoie <j.lavoie@net-c.ca> Co-authored-by: Michal L <michalrmsmi@wp.pl> Co-authored-by: Software In Interlingua <softinterlingua@gmail.com> Co-authored-by: TiA4f8R <avdivers84@gmail.com> Co-authored-by: TobiGr <tobigr@mail.de> Co-authored-by: VfBFan <drop0815@posteo.de> Co-authored-by: chr56 <chr0056@gmail.com> Co-authored-by: nautilusx <translate@disroot.org> Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/ Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/ Translation: NewPipe/Metadata
Increase width of metadata text view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
App
New
Improved
Fixed
subscribe()in DownloadDialog Error handling in subscribe() in DownloadDialog #6118Development
Extractor
New
getService()to Info object Design and theme issues #646Improved
Fixed
Development
MetaInfoTest.expectedMetaInfoFix MetaInfoTest.expectedMetaInfo NewPipeExtractor#630APK for tesing
app.zip from CI
Please report new bugs in #6433