-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YouTube] Fix broken likes in comments #6337
Conversation
You need to update the NewPipeExtractor dependency and change it to your fork |
This PR may no longer be required, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As asked in TeamNewPipe/NewPipeExtractor#628 (review), please round the count using Localization.shortCount()
ac7462c
to
c7660b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still shows 0 likes.
You have to update the extracton version to the last dev commit:
Copy the commit hash from here https://github.com/TeamNewPipe/NewPipeExtractor/commits
Replace v0.21.3 by the commit hash here
Line 186 in f739ed7
implementation 'com.github.TeamNewPipe:NewPipeExtractor:v0.21.3' |
What is it?
Description of the changes in your PR
Demo:
Fixes the following issue(s)
Relies on the following changes
APK testing
On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.
Due diligence