Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub actions from Travis #506

Merged
merged 3 commits into from
Jan 1, 2021
Merged

Migrate to GitHub actions from Travis #506

merged 3 commits into from
Jan 1, 2021

Conversation

TobiGr
Copy link
Member

@TobiGr TobiGr commented Dec 31, 2020

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

This PR supersedes #496 and therefore closes #496.
Thanks to @FireMasterK for doing the initial (and most) work!

I fixed the JDoc deployment and updated the link for Java SE components.
This PR targets master for technical reasons (such as getting the JDoc deployed asap).

To Do / Needs to be fixed later

  • Cache builds although the tests fail.

@FireMasterK
Copy link
Member

You can't really fix the caching on a build failure, see: actions/cache#92.

However, a workaround is to fork the cache action and then do something like gerbal/always-cache, but that's going to require some maintenance work.

However, it shouldn't be too big of an issue considering these builds last 2 minutes.

@TobiGr
Copy link
Member Author

TobiGr commented Jan 1, 2021

Yes, you are right.

I'll merge this now. We can improve this later if necessary

@TobiGr TobiGr merged commit c4b9183 into master Jan 1, 2021
@TobiGr TobiGr deleted the gh-actions branch January 1, 2021 09:35
@TobiGr TobiGr mentioned this pull request Jan 18, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants