Adjust CI workflow to run tests with mocks #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now MockDownloader will be used in tests.
Stypox
approved these changes
Jan 15, 2021
Not that much. With big bugs, we will get flooded with issues about it (like new yt-decrypt format). Small ones aren't getting fixed (See the amount of failing tests and for how long they are already failing). But now i know more about github actions and can easily just combine them into a single file i think. |
I agree with you. I'm merging this, thank you :-D |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that all tests that are already using mocks (currently only
YoutubeMixPlaylistExtractorTest) will not test against the real Websites anymore. For that a new job needs to be added.