-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add if-else statement to run tests against real website on schedule #516
Conversation
I like this! Is it really that simple? :-D |
Should be. |
@Stypox let the action on my repo run for a night and tomorrow we can see if it echoed the correct thing |
Seeing how there already are new failing tests not even an hour after merging #512, we probably need a way to mark tests to be skipped in the ci pipeline if they are not run with mocks. |
@XiangRongLin good idea |
It works |
Great! @TobiGr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged once review is implemented
cb13d0c
to
7a6d930
Compare
Ah wait. wasn't there a complaint regarding automated testing when they took down youtube-dl? @TheAssassin This introduces sheduled tests against the real websites, whereas some predefined JSONs are tested against PRs. Is that ok? |
@TobiGr I think part of it was that there we unit tests, that were downloading copyrighted stuff see last paragraph of this section https://github.blog/2020-11-16-standing-up-for-developers-youtube-dl-is-back/#youtube-dl So we would need to check all tests once and see if there are any such tests and replace them |
I realized that running the tests against real website is basically just copying the ci.yml and changing one value.
Which can also be done with an if condition.
Because github actions
if
has noelse
, the shell script ones are used