[YouTube Music] Fix extracting search item view/subscriber count when = 0 #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
TobiGr
reviewed
Jan 27, 2021
| @@ -105,7 +108,7 @@ public void onFetchPage(@Nonnull final Downloader downloader) throws IOException | |||
| .end() | |||
| .value("query", getSearchString()) | |||
| .value("params", params) | |||
| .end().done().getBytes("UTF-8"); | |||
| .end().done().getBytes(StandardCharsets.UTF_8); | |||
There was a problem hiding this comment.
Is that going to break compatibility with the legacy version?
Or can we use that safely, because this is a precoompiled lib?
StandardCharset were added with API 19 to Android: https://developer.android.com/reference/java/nio/charset/StandardCharsets
There was a problem hiding this comment.
Oh, I have no idea, I can revert that commit if needed
There was a problem hiding this comment.
See #269
We should remove the other occurencies of that class, too.
There was a problem hiding this comment.
There's an issue to provide a backport: https://issuetracker.google.com/issues/169047771
There was a problem hiding this comment.
thanks. I searched for that class, but only found an unused import (see d728c4f).
TobiGr
approved these changes
Jan 29, 2021
TobiGr
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the comment TeamNewPipe/NewPipe#5455 (comment)