Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for a CommentsInfo instance in CommentsInfo.getMoreItems and fix PeertubeCommentsExtractorTest.Default test #807

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Remove the need for a CommentsInfo instance in CommentsInfo.getMoreItems and fix PeertubeCommentsExtractorTest.Default test #807

merged 1 commit into from
Mar 15, 2022

Conversation

FireMasterK
Copy link
Member

@FireMasterK FireMasterK commented Mar 3, 2022 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

I also fixed the Peertube comments test.

Closes #697, this is important for Piped since these instances are currently cached in memory

@FireMasterK FireMasterK mentioned this pull request Mar 3, 2022
Merged
@AudricV AudricV changed the title Remove the need for a CommentsInfo instance Remove the need for a CommentsInfo instance in CommentsInfo.getMoreItems and fix PeertubeCommentsExtractorTest.Default test Mar 12, 2022
@AudricV AudricV added enhancement peertube service, https://joinpeertube.org/ multiservice Issues related to multiple services labels Mar 12, 2022
litetex
litetex approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

commentsInfo.getCommentsExtractor().fetchPage(); should be tested with NewPipe

@FireMasterK
Copy link
Member Author

commentsInfo.getCommentsExtractor().fetchPage(); should be tested with NewPipe

I have built and tested this with NewPipe, and it worked perfectly. Are you referring to Unit tests? I think they can be added in a different PR

@litetex
Copy link
Member

litetex commented Mar 15, 2022

I have built and tested this with NewPipe, and it worked perfectly.

Ok, that's great. Then merge it is 😄

Are you referring to Unit tests? I think they can be added in a different PR

No (there is already #813 for fixing these problems)

@litetex litetex merged commit e7aee0c into TeamNewPipe:dev Mar 15, 2022
@FireMasterK FireMasterK deleted the no-commentsinfo-instance branch March 15, 2022 18:12
@litetex litetex mentioned this pull request Mar 26, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litetex litetex litetex approved these changes

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
enhancement multiservice Issues related to multiple services peertube service, https://joinpeertube.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CommentsInfo.getMoreItems requires a CommentsInfo instance
4 participants
@FireMasterK @litetex @Stypox @AudricV