Fixed tests (+ Youtube shorts in channels) #813
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
litetex
force-pushed
the
fix-test-2022-03
branch
from
0a4d84a
to
a14fbcb
Compare
|
Tested the changes with NewPipe and they work fine. Followup after merge:
|
When I did this TeamNewPipe/NewPipe#8034 (comment), new shorts showed with their correct duration. Is it an intermittent change that will eventually become permanent? |
From: TeamNewPipe/NewPipe#8034 (comment)
|
|
Indeed. The "Not loaded" channel number is constant for me now. No change even after repeated refreshes. |
...st/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCRecentListExtractorTest.java
Outdated
Show resolved
Hide resolved
| @@ -130,6 +130,7 @@ public static void setUp() throws Exception { | |||
| @Override public InfoItem.InfoType expectedInfoItemType() { return InfoItem.InfoType.CHANNEL; } | |||
| } | |||
|
|
|||
| @Disabled("Currently constantly switching between \"Did you mean\" and \"Showing results for ...\" occurs") | |||
There was a problem hiding this comment.
You could make this @MockOnly instead for now, since we still want to test that the code correctly extracts the suggestion from the stored mocks.
There was a problem hiding this comment.
Useless in my opinion because the tests are based on outdated data when running the test.
The actual extraction inside e.g. NewPipe can still fail and the test says that everything is ok.
There was a problem hiding this comment.
That's true, but at least the test can be used to verify that code changes inside NewPipeExtractor don't break currently working features.
There was a problem hiding this comment.
Note: "Fixed" inside YoutubeSearchExtractorTest.java but YoutubeMusicSearchExtractorTest$Suggestion has no mock data, so I can't fix it there...
...st/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorTest.java
Outdated
Show resolved
Hide resolved
litetex
force-pushed
the
fix-test-2022-03
branch
from
6c2abe9
to
8c195e2
Compare
|
Update:
|
* Use assertAll * Show which item is affected
Old comments/videos got deleted
Ignore faulty data/items (with duration <= 0)
As a workaround 0 is returned as duration for such videos. See also TeamNewPipe/NewPipe#8034
Has to be done once YT's backed works again...
* Made the reason why the tests are mockonly mandatory
litetex
force-pushed
the
fix-test-2022-03
branch
from
6a31211
to
29408f9
Compare
litetex
dismissed
Stypox’s stale review
Stypox is for the next weeks really busy, the problems got fixed and this can't wait any longer
The following tests are currently failing when I run them locally:
MediaCCCRecentListExtractorTest.testStreamList()No feedback... Applying workaround: Ignore faulty items
PeertubeCommentsExtractorTest$Default.testGetComments()and
.testGetCommentsFromCommentsInfo()PeertubeStreamExtractorTest$WhatIsPeertube.testLikeCount()YoutubeMixPlaylistExtractorTest$Mix.getName()YoutubeMixPlaylistExtractorTest$MixWithIndex.getName()YoutubeMusicSearchExtractorTest$Suggestion.testSearchCorrected()YoutubeMusicSearchExtractorTest$Suggestion.testSearchSuggestion()YoutubeSearchExtractorTest$Suggestion.testSearchCorrected()Constantly switching between "Did you mean" and "Showing results for ..." occurs:
YoutubeStreamExtractorControversialTest.testSubscriberCount()YoutubeChannelExtractorTest$VSauce.testRelatedItems()