feat(popup): support background,border-radius,safe-area #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeJim
requested changes
Mar 14, 2023
LeeJim
approved these changes
Mar 14, 2023
Merged
LeeJim
added a commit
that referenced
this pull request
Mar 14, 2023
* fix(SwipeCell): fix docs (#1634) * fix(Dialog): fix button style (#1633) * fix(loading): update loading color (#1627) * Refactor/loading remove (#1626) * fix(loading): remove bar and error theme * test(loading): update * test(image-viewer): update snapshot * chore(Cell): adjust className for hover-class (#1635) * chore(Cell): adjust className for hover-class * test: update snapshots * chore(Picker&&DateTimePicker): remove footer slot (#1631) * chore(Radio): align attribute is renamed to placement (#1630) * chore(Checkbox): align attribute is renamed to placement (#1629) * chore(Search): remove the right-icon and add the clearable attribute (#1628) * feat(button): support suffix slot (#1624) * feat(button): support suffix slot * test(button): update snapshot * chore(Avatar): remove bordered attribute (#1632) * chore(Avatar): remove bordered attribute * fix: fix cr * chore(Message): remove action and add the link attribute (#1637) * chore(Message): remove action and add the link attribute * fix: fix cr * fix(navbar): resolve capsule event currectly (#1641) * chore(Footer): copyright attribute is renamed to text (#1642) * chore(Footer): copyright attribute is renamed to text * chore(CountDown): remove theme attribute * fix(dialog): resolve word misspelling (#1644) * chore(CountDown): remove hightlight theme (#1645) * fix(slider): 规范无障碍语义. (#1388) * fix(slider): 规范无障碍语义 * fix(slider): 无障碍滑块valuetext规范.(#1402) * fix(slider): 无用动态百分比播报问题.(#1402) * fix(slider): 隐藏数值读取.(#1402) * fix(slider): 隐藏数值读取.(#1402) * fix(slider): 变量规范.(#1402) * docs(steps): update api * fix(toast): replace fail theme with error (#1647) * docs: update api & changelog * fix: fix overview.md errors (#1651) * fix: update pages * fix(collapse): resolve disabled color (#1648) * fix(collapse): resolve disabled color * test: update snapshot * chore(Link): remove status and add disabled and hover (#1652) * chore(Link): remove status and add disabled and hover * feat(Link): support external-classes * feat(Drawer): add hover style (#1673) * fix(Tag): use catch to bind events (#1669) * fix(rate): remove variant property and update tips disapper logic (#1674) * fix(rate): remove variant property and update tips disapper logic * test(rate): update snapshot * fix(BackTop): fix icon (#1660) * fix(Picker): update demo (#1661) * fix: update sidebar of the site (#1659) * docs(common): update design docs (#1658) * fix(SideBar): fix inaccurate positioning when the page was init (#1675) * fix(slider): remove colors and disabledColor property (#1676) * feat(AvatarGroup): add border style (#1678) * fix(dialog): resolve action tsd error and support buttonLayout (#1654) (#1655) * chore(NoticeBar): extra attribute is renamed to operation (#1638) * fix(Cell): resolve demo problems (#1679) * chore: publish v1.0.0 (#1680) * chore: publish v1.0.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * docs: update changelog * chore: update common * fix(action-sheet): add close event (#1683) * fix(cascader): resolve events (#1685) * fix(drawer): resolve close event (#1686) * feat(picker): add close event (#1687) * feat(picker): add close event * test(date-time-picker): update snapshots * fix(Message): fix t-class-link invalid (#1690) * fix: fix docs * fix(Message): fix t-class-link invalid * fix: fix docs (#1688) * feat(upload): support aria (#1238) * feat(upload): support aria * chore(upload): update snap * feat(upload): icon hidden * feat(upload): hack * revert(upload): revert grid * chore(upload): update snap * feat(upload): file.status * feat(upload): enhance * feat(upload): upload wxs * feat(upload): enhance * feat(upload): add button role * feat(upload): remove aria-labelledby="{{labelID}}" * feat(upload): ariaLabel labelledby * feat(grid): describedby * feat(upload): optimization * fix: resolve radio placement (#1693) * fix(Message): fix demo for message (#1694) * chore: publish v1.0.1 (#1695) * chore: publish v1.0.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: add test:snap-update (#1706) * fix: update api for checkbox and radio (#1707) * fix: update api for checkbox and radio * chore: update demo * test(radio): update snapshot * fix(action-sheet): resolve click event (#1726) * feat: update used page (#1734) * fix(Swiper): resolve border radius invalid (#1733) * docs: update changelog * fix(navbar): resolve extenal class (#1735) * fix(navbar): resolve extenal class * test(navbar): update snapshot * docs(Footer): update docs (#1737) * fix(Swiper): the image is disappears when the version is lower than 2.19.2 (#1736) * chore(ImageViewer): resolved imageViewer display is incomplete (#1656) * chore(ImageViewer): remove backgroundColor attribute * fix(ImageViewer): update images * fix: fix cr * fix(image-viewer): recover background-colorproperty --------- Co-authored-by: leejimqiu <leejimqiu@gmail.com> * fix(Input): resolve maxLength invalid (#1732) * fix(Input): resolve maxlength invalid * chore(Input): clear event uses touchstart * test: update snapshots * chore: publish v1.0.2 (#1740) * chore: publish v1.0.2 * docs: update changelog * fix(dropdown-menu): resolve label and radio icon placement (#1748) * Update README.md (#1751) 删除文档多余的两个空行 * fix(popup): resolve close can not tap (#1754) * fix(calendar): resolve format property reactive (#1753) * fix(calendar): resolve format property reactive * fix(calendar): resolve format property * fix: fix docs for upload and icon components (#1752) * feat(picker): support keys property (#1759) * feat(picker): support keys property * fix(picker): remove info about columns property * fix(checkbox): resolve check all when some is diabled (#1766) * fix(badge): resolve color property (#1764) * feat(Input): support bindnicknamereview (#1755) * fix(upload): make size-limit support object (#1763) * fix(upload): make size-limit support object * test(upload): update * fix(Button): fix disabled invalid (#1739) * fix(Button): fix disabled invalid * fix: fix cr * fix(grid | cell | tabs | tabbar | sliderBar): 有 badge，有新的消息、不朗读异常 (#1428) * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix tabs aira * fix: slid-bar aira * fix: cell demo aira * test: update snap * fix: fix code * test: update snap * fix: fix code * fix: fix demo * test: update snap * fix: fix code * test: update snap * test: update snap update snap * fix: 优化demo * fix: update snap * fix: 优化朗读文案 * test: update snap * fix: 优化朗读role的使用方式 * test: update snap * fix: 改变朗读的通用方法 * fix: 优化方法 * test: update snap * fix: 修改注释 * test: update snap' * fix: 补充demo * fix: update demo * fix: 优化 * fix: remove demo * fix: 解决冲突 --------- Co-authored-by: leejimqiu <leejimqiu@gmail.com> * chore: update projects who use tdesign * fix(Cell): resolve the incomplete display of note content (#1769) * feat(wxs): the style attr supports camel case (#1744) * feat(popup): support background,border-radius,safe-area (#1758) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(Progress): resolve slot invalid when label is true (#1771) * fix(grid): resolve image slot (#1772) * chore: publish v1.0.3 (#1774) * chore: publish v1.0.3 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: byqbai <byq1213@qq.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhangpaopao <zhangpaopao0609@gmail.com> Co-authored-by: hezhi3f <58511226+hezhi3f@users.noreply.github.com> Co-authored-by: 龙风 <455947455@qq.com>
LeeJim
added a commit
that referenced
this pull request
Mar 20, 2023
* fix(SwipeCell): fix docs (#1634) * fix(Dialog): fix button style (#1633) * fix(loading): update loading color (#1627) * Refactor/loading remove (#1626) * fix(loading): remove bar and error theme * test(loading): update * test(image-viewer): update snapshot * chore(Cell): adjust className for hover-class (#1635) * chore(Cell): adjust className for hover-class * test: update snapshots * chore(Picker&&DateTimePicker): remove footer slot (#1631) * chore(Radio): align attribute is renamed to placement (#1630) * chore(Checkbox): align attribute is renamed to placement (#1629) * chore(Search): remove the right-icon and add the clearable attribute (#1628) * feat(button): support suffix slot (#1624) * feat(button): support suffix slot * test(button): update snapshot * chore(Avatar): remove bordered attribute (#1632) * chore(Avatar): remove bordered attribute * fix: fix cr * chore(Message): remove action and add the link attribute (#1637) * chore(Message): remove action and add the link attribute * fix: fix cr * fix(navbar): resolve capsule event currectly (#1641) * chore(Footer): copyright attribute is renamed to text (#1642) * chore(Footer): copyright attribute is renamed to text * chore(CountDown): remove theme attribute * fix(dialog): resolve word misspelling (#1644) * chore(CountDown): remove hightlight theme (#1645) * fix(slider): 规范无障碍语义. (#1388) * fix(slider): 规范无障碍语义 * fix(slider): 无障碍滑块valuetext规范.(#1402) * fix(slider): 无用动态百分比播报问题.(#1402) * fix(slider): 隐藏数值读取.(#1402) * fix(slider): 隐藏数值读取.(#1402) * fix(slider): 变量规范.(#1402) * docs(steps): update api * fix(toast): replace fail theme with error (#1647) * docs: update api & changelog * fix: fix overview.md errors (#1651) * fix: update pages * fix(collapse): resolve disabled color (#1648) * fix(collapse): resolve disabled color * test: update snapshot * chore(Link): remove status and add disabled and hover (#1652) * chore(Link): remove status and add disabled and hover * feat(Link): support external-classes * feat(Drawer): add hover style (#1673) * fix(Tag): use catch to bind events (#1669) * fix(rate): remove variant property and update tips disapper logic (#1674) * fix(rate): remove variant property and update tips disapper logic * test(rate): update snapshot * fix(BackTop): fix icon (#1660) * fix(Picker): update demo (#1661) * fix: update sidebar of the site (#1659) * docs(common): update design docs (#1658) * fix(SideBar): fix inaccurate positioning when the page was init (#1675) * fix(slider): remove colors and disabledColor property (#1676) * feat(AvatarGroup): add border style (#1678) * fix(dialog): resolve action tsd error and support buttonLayout (#1654) (#1655) * chore(NoticeBar): extra attribute is renamed to operation (#1638) * fix(Cell): resolve demo problems (#1679) * chore: publish v1.0.0 (#1680) * chore: publish v1.0.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * docs: update changelog * chore: update common * fix(action-sheet): add close event (#1683) * fix(cascader): resolve events (#1685) * fix(drawer): resolve close event (#1686) * feat(picker): add close event (#1687) * feat(picker): add close event * test(date-time-picker): update snapshots * fix(Message): fix t-class-link invalid (#1690) * fix: fix docs * fix(Message): fix t-class-link invalid * fix: fix docs (#1688) * feat(upload): support aria (#1238) * feat(upload): support aria * chore(upload): update snap * feat(upload): icon hidden * feat(upload): hack * revert(upload): revert grid * chore(upload): update snap * feat(upload): file.status * feat(upload): enhance * feat(upload): upload wxs * feat(upload): enhance * feat(upload): add button role * feat(upload): remove aria-labelledby="{{labelID}}" * feat(upload): ariaLabel labelledby * feat(grid): describedby * feat(upload): optimization * fix: resolve radio placement (#1693) * fix(Message): fix demo for message (#1694) * chore: publish v1.0.1 (#1695) * chore: publish v1.0.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: add test:snap-update (#1706) * fix: update api for checkbox and radio (#1707) * fix: update api for checkbox and radio * chore: update demo * test(radio): update snapshot * fix(action-sheet): resolve click event (#1726) * feat: update used page (#1734) * fix(Swiper): resolve border radius invalid (#1733) * docs: update changelog * fix(navbar): resolve extenal class (#1735) * fix(navbar): resolve extenal class * test(navbar): update snapshot * docs(Footer): update docs (#1737) * fix(Swiper): the image is disappears when the version is lower than 2.19.2 (#1736) * chore(ImageViewer): resolved imageViewer display is incomplete (#1656) * chore(ImageViewer): remove backgroundColor attribute * fix(ImageViewer): update images * fix: fix cr * fix(image-viewer): recover background-colorproperty --------- Co-authored-by: leejimqiu <leejimqiu@gmail.com> * fix(Input): resolve maxLength invalid (#1732) * fix(Input): resolve maxlength invalid * chore(Input): clear event uses touchstart * test: update snapshots * chore: publish v1.0.2 (#1740) * chore: publish v1.0.2 * docs: update changelog * fix(dropdown-menu): resolve label and radio icon placement (#1748) * Update README.md (#1751) 删除文档多余的两个空行 * fix(popup): resolve close can not tap (#1754) * fix(calendar): resolve format property reactive (#1753) * fix(calendar): resolve format property reactive * fix(calendar): resolve format property * fix: fix docs for upload and icon components (#1752) * feat(picker): support keys property (#1759) * feat(picker): support keys property * fix(picker): remove info about columns property * fix(checkbox): resolve check all when some is diabled (#1766) * fix(badge): resolve color property (#1764) * feat(Input): support bindnicknamereview (#1755) * fix(upload): make size-limit support object (#1763) * fix(upload): make size-limit support object * test(upload): update * fix(Button): fix disabled invalid (#1739) * fix(Button): fix disabled invalid * fix: fix cr * fix(grid | cell | tabs | tabbar | sliderBar): 有 badge，有新的消息、不朗读异常 (#1428) * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix tabs aira * fix: slid-bar aira * fix: cell demo aira * test: update snap * fix: fix code * test: update snap * fix: fix code * fix: fix demo * test: update snap * fix: fix code * test: update snap * test: update snap update snap * fix: 优化demo * fix: update snap * fix: 优化朗读文案 * test: update snap * fix: 优化朗读role的使用方式 * test: update snap * fix: 改变朗读的通用方法 * fix: 优化方法 * test: update snap * fix: 修改注释 * test: update snap' * fix: 补充demo * fix: update demo * fix: 优化 * fix: remove demo * fix: 解决冲突 --------- Co-authored-by: leejimqiu <leejimqiu@gmail.com> * chore: update projects who use tdesign * fix(Cell): resolve the incomplete display of note content (#1769) * feat(wxs): the style attr supports camel case (#1744) * feat(popup): support background,border-radius,safe-area (#1758) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(Progress): resolve slot invalid when label is true (#1771) * fix(grid): resolve image slot (#1772) * chore: publish v1.0.3 (#1774) * chore: publish v1.0.3 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(pull-down-refresh.wxml): pull-down-refresh无障碍支持 (#1241) feat #1071 * docs(radio): update api * fix(Textarea): resolve the style problem when autosize is true (#1781) * feat(step aria): step aria (#1783) * chore: update site-components (#1795) * fix(upload): 修复upload点击事件失效问题 (#1802) * fix: 修复upload点击事件失效问题 * test: update snap * fix(switch): resolve label and icon (#1809) * fix(loading): resolve style error (#1810) * chore: add new project * fix(radio): resolve placement (#1812) * fix(button): resolve multiple slot (#1813) * fix(upload): 修复limit限制的问题 (#1800) * fix: 修复limit限制的问题 fix #1779 * fix: fix code * test: update snap * build: add workflow for issue labeld * fix: resolve multiple slots (#1816) * chore: publish v1.0.4 (#1818) * chore: publish v1.0.4 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: byqbai <byq1213@qq.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhangpaopao <zhangpaopao0609@gmail.com> Co-authored-by: hezhi3f <58511226+hezhi3f@users.noreply.github.com> Co-authored-by: 龙风 <455947455@qq.com> Co-authored-by: shinyina <92632534+shinyina@users.noreply.github.com> Co-authored-by: jerimizhang <3435677954@qq.com> Co-authored-by: Kyrielin <a154571896@gmail.com>
LeeJim
pushed a commit
that referenced
this pull request
Mar 26, 2023
* fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name
LeeJim
added a commit
that referenced
this pull request
Mar 27, 2023
* docs: update custom theme * 新增layout布局 (#1821) * feat(layout): add a new component feat #1701 * fix: 修复代码 * fix: 修复PR问题 * build: update issue label workflow * Docs/layout (#1822) * chore(layout): add docs and property file * chore: update layout url * fix(col): update api * fix: cls函数支持传入数值类型 (#1827) * 修复 button 组件 disableb 对控制 tap 无效问题 (#1833) * fix: button的tap事件没触发 fix #1797 * fix: disableb 对控制 tap 无效 * fix: fix lint question * feat(search): add type prop to input component (#1828) add type prop to input component fix #1793 * fix(NoticeBar): resolve scroll (#1835) * fix(checkbox): placement name in demo is wrong (#1836) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * feat(pulldownrefresh): add default value to loading-texts (#1837) * feat(pulldownrefresh): add default value to loading-texts add default value to loading-texts * fix(pulldownrefresh): add default value to loading-texts #1806 * fix(pulldown-refresh): resolve external class (#1839) * chore: add layout on overview page * fix(grid): resolve image class (#1842) * fix(notice-bar): fix loop prop (#1826) fix notice-bar loop issue * fix(cascader): resolve options when value changed (#1841) * fix(tabs): resolve animation and uncaught error (#1843) * fix(tabs): remove scroll bar (#1844) * chore: publish v1.1.0 (#1845) * chore: publish v1.1.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: pingwu <58472278+wuping97@users.noreply.github.com> Co-authored-by: Haochen Li <lihaochen2017@outlook.com> Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LeeJim
added a commit
that referenced
this pull request
Apr 4, 2023
* docs: update custom theme * 新增layout布局 (#1821) * feat(layout): add a new component feat #1701 * fix: 修复代码 * fix: 修复PR问题 * build: update issue label workflow * Docs/layout (#1822) * chore(layout): add docs and property file * chore: update layout url * fix(col): update api * fix: cls函数支持传入数值类型 (#1827) * 修复 button 组件 disableb 对控制 tap 无效问题 (#1833) * fix: button的tap事件没触发 fix #1797 * fix: disableb 对控制 tap 无效 * fix: fix lint question * feat(search): add type prop to input component (#1828) add type prop to input component fix #1793 * fix(NoticeBar): resolve scroll (#1835) * fix(checkbox): placement name in demo is wrong (#1836) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * feat(pulldownrefresh): add default value to loading-texts (#1837) * feat(pulldownrefresh): add default value to loading-texts add default value to loading-texts * fix(pulldownrefresh): add default value to loading-texts #1806 * fix(pulldown-refresh): resolve external class (#1839) * chore: add layout on overview page * fix(grid): resolve image class (#1842) * fix(notice-bar): fix loop prop (#1826) fix notice-bar loop issue * fix(cascader): resolve options when value changed (#1841) * fix(tabs): resolve animation and uncaught error (#1843) * fix(tabs): remove scroll bar (#1844) * chore: publish v1.1.0 (#1845) * chore: publish v1.1.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(Button): add hover-class attr (#1847) * fix(tabs): resolve content overlay (#1853) * fix(Message): resolve marquee (#1856) * fix(avatar): resolve "bordered" is overwritten warning (#1849) (#1858) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * fix(avatar): resolve "bordered" is overwritten warning (#1849) * fix(avatar): add borderedWithGroup attr * fix(drawer): resolve destroyOnClose error (#1864) * chore: publish v1.1.1 (#1867) * chore: publish v1.1.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: pingwu <58472278+wuping97@users.noreply.github.com> Co-authored-by: Haochen Li <lihaochen2017@outlook.com> Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
使用popup大多数场景希望有背景色、背景圆角、bottom场景希望有安全底边距
去掉所有依赖popup的组件设置的safe-area，统一在popup添加
📝 更新日志
feat(Popup): 增加默认圆角、默认背景色、安全底边距
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单