fix(notice-bar): fix loop prop #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix notice-bar loop issue
haochenli
force-pushed
the
fix/haochenli/notice-bar
branch
from
33c6ab3
to
5df3350
Compare
anlyyao
reviewed
Mar 24, 2023
LeeJim
approved these changes
Mar 27, 2023
Merged
LeeJim
added a commit
that referenced
this pull request
Mar 27, 2023
* docs: update custom theme * 新增layout布局 (#1821) * feat(layout): add a new component feat #1701 * fix: 修复代码 * fix: 修复PR问题 * build: update issue label workflow * Docs/layout (#1822) * chore(layout): add docs and property file * chore: update layout url * fix(col): update api * fix: cls函数支持传入数值类型 (#1827) * 修复 button 组件 disableb 对控制 tap 无效问题 (#1833) * fix: button的tap事件没触发 fix #1797 * fix: disableb 对控制 tap 无效 * fix: fix lint question * feat(search): add type prop to input component (#1828) add type prop to input component fix #1793 * fix(NoticeBar): resolve scroll (#1835) * fix(checkbox): placement name in demo is wrong (#1836) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * feat(pulldownrefresh): add default value to loading-texts (#1837) * feat(pulldownrefresh): add default value to loading-texts add default value to loading-texts * fix(pulldownrefresh): add default value to loading-texts #1806 * fix(pulldown-refresh): resolve external class (#1839) * chore: add layout on overview page * fix(grid): resolve image class (#1842) * fix(notice-bar): fix loop prop (#1826) fix notice-bar loop issue * fix(cascader): resolve options when value changed (#1841) * fix(tabs): resolve animation and uncaught error (#1843) * fix(tabs): remove scroll bar (#1844) * chore: publish v1.1.0 (#1845) * chore: publish v1.1.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: pingwu <58472278+wuping97@users.noreply.github.com> Co-authored-by: Haochen Li <lihaochen2017@outlook.com> Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LeeJim
added a commit
that referenced
this pull request
Apr 4, 2023
* docs: update custom theme * 新增layout布局 (#1821) * feat(layout): add a new component feat #1701 * fix: 修复代码 * fix: 修复PR问题 * build: update issue label workflow * Docs/layout (#1822) * chore(layout): add docs and property file * chore: update layout url * fix(col): update api * fix: cls函数支持传入数值类型 (#1827) * 修复 button 组件 disableb 对控制 tap 无效问题 (#1833) * fix: button的tap事件没触发 fix #1797 * fix: disableb 对控制 tap 无效 * fix: fix lint question * feat(search): add type prop to input component (#1828) add type prop to input component fix #1793 * fix(NoticeBar): resolve scroll (#1835) * fix(checkbox): placement name in demo is wrong (#1836) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * feat(pulldownrefresh): add default value to loading-texts (#1837) * feat(pulldownrefresh): add default value to loading-texts add default value to loading-texts * fix(pulldownrefresh): add default value to loading-texts #1806 * fix(pulldown-refresh): resolve external class (#1839) * chore: add layout on overview page * fix(grid): resolve image class (#1842) * fix(notice-bar): fix loop prop (#1826) fix notice-bar loop issue * fix(cascader): resolve options when value changed (#1841) * fix(tabs): resolve animation and uncaught error (#1843) * fix(tabs): remove scroll bar (#1844) * chore: publish v1.1.0 (#1845) * chore: publish v1.1.0 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat(Button): add hover-class attr (#1847) * fix(tabs): resolve content overlay (#1853) * fix(Message): resolve marquee (#1856) * fix(avatar): resolve "bordered" is overwritten warning (#1849) (#1858) * fix(popup): resolve close can not tap * feat(popup): support background,border-radius,safe-area * fix(popup): add less variable (#1758) * fix(checkbox): placement name * fix(avatar): resolve "bordered" is overwritten warning (#1849) * fix(avatar): add borderedWithGroup attr * fix(drawer): resolve destroyOnClose error (#1864) * chore: publish v1.1.1 (#1867) * chore: publish v1.1.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: pingwu <58472278+wuping97@users.noreply.github.com> Co-authored-by: Haochen Li <lihaochen2017@outlook.com> Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Wang <awangjianjun9@gmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the loop props is 0, the notice-bar should not loop
fix #1808
🤔 这个 PR 的性质是？
🔗 相关 Issue
#1808
💡 需求背景和解决方案
修复notice-bar中的marquee的loop为0时还会播放的问题。并验证了loop>0和loop<0的情况
📝 更新日志
fix(NoticeBar): 修复 loop 为 0 时还会循环播放的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单