Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address IntelliJ QAPlug plugin findings #114

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Oct 22, 2023

  • remove unused imports

Relates to MovingBlocks/Terasology#5149

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance labels Oct 22, 2023
jdrueckert added a commit to MovingBlocks/Terasology that referenced this pull request Nov 11, 2023
* make final fields static
* remove unnecessary local before return
* remove instanceof checks in catch clause
* avoid throwing java.lang.Exception
* remove null checks covered by instanceof check
* remove toString on String objects
* remove overrides that only call their super
* remove unused private methods
* remove unnecessary if statement nesting
* remove unused local variables
* use try-with-resources to close resources after use
* use equals() to compare object references
* fix broken javadoc references
* fix disallowed self-closing and empty javadoc elements
* fix bad use of symbols in javadoc
* fix disallowed list item tag in javadoc without surrounding list
* fix erroneous javadoc tags
* fix emphasize tags in javadoc
* remove illegal throws
* remove unused imports

Related:
Terasology/CoreRendering#75
Terasology/Furnishings#17
Terasology/Health#105
Terasology/Inventory#51
Terasology/Behaviors#114
Terasology/CoreWorlds#45
Terasology/FlexiblePathfinding#32

Adds to #3859
@jdrueckert
Copy link
Member Author

Test fails due to the issue being fixed by #115 so we should only merge this after merging #115

@soloturn
Copy link

i cannot follow this logic @jdrueckert - this is just reordering imports. no relation with test failures? and #115 itself has test failures.

@skaldarnar
Copy link
Contributor

@soloturn The module is broken currently due to a change in the engine. As the modules don't define on which version of the engine they depend, and the CI always takes the latest available build of develop as base a previously working state of a module might become broken 😔

In this case, even develop is not passing CI, see https://jenkins.terasology.io/job/Terasology/job/Modules/job/B/job/Behaviors/job/develop/1/.

If I understand @jdrueckert correctly, the proposal is to fix the build failure first (intented by #115) before merging anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants