Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address IntelliJ QAPlug plugin findings #51

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Oct 22, 2023

  • remove unused imports
  • remove unnecessary if statement nesting
  • remove redundant public modifier

Relates to MovingBlocks/Terasology#5149

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance labels Oct 22, 2023
jdrueckert added a commit to MovingBlocks/Terasology that referenced this pull request Nov 11, 2023
* make final fields static
* remove unnecessary local before return
* remove instanceof checks in catch clause
* avoid throwing java.lang.Exception
* remove null checks covered by instanceof check
* remove toString on String objects
* remove overrides that only call their super
* remove unused private methods
* remove unnecessary if statement nesting
* remove unused local variables
* use try-with-resources to close resources after use
* use equals() to compare object references
* fix broken javadoc references
* fix disallowed self-closing and empty javadoc elements
* fix bad use of symbols in javadoc
* fix disallowed list item tag in javadoc without surrounding list
* fix erroneous javadoc tags
* fix emphasize tags in javadoc
* remove illegal throws
* remove unused imports

Related:
Terasology/CoreRendering#75
Terasology/Furnishings#17
Terasology/Health#105
Terasology/Inventory#51
Terasology/Behaviors#114
Terasology/CoreWorlds#45
Terasology/FlexiblePathfinding#32

Adds to #3859
soloturn
soloturn previously approved these changes Nov 18, 2023
@jdrueckert
Copy link
Member Author

@soloturn thanks for the approval! I need to sort out our GitHub teams so that you can actually approve 🙈

@soloturn
Copy link
Contributor

@jdrueckert i would really appreciate if you merge this one or get it merged.

* line too long
* logger not parameterized
* intellij warnings about formatting, e.g. @ReceiveEvent(components = {InventoryComponent.class}) replaced with  @ReceiveEvent(components = InventoryComponent.class)
* unused private field
@soloturn
Copy link
Contributor

seems approve worked thank you @jdrueckert . but merge button is not active. is it for you?

@jdrueckert
Copy link
Member Author

jdrueckert commented Nov 29, 2023

seems approve worked thank you @jdrueckert . but merge button is not active. is it for you?

It is not active for me either which is due to the fact that the pipeline hasn't passed.
Our develop branches are protected. In order to merge a PR to them, the PR needs to be approved and pass the checks.
Only administrators can bypass these branch protections.

Now that we have our module pipelines set up again (after our recent CI changes), we can run the pipeline again and if it passes - which I'm expecting it to do - we can go ahead and merge.

@jdrueckert jdrueckert merged commit 0fadffa into develop Nov 29, 2023
11 checks passed
@jdrueckert jdrueckert deleted the chore/qaplug-findings branch November 29, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants