Added Genome related events #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxi
reviewed
Jun 26, 2020
There was a problem hiding this comment.
Overall seems fine,
I am a little bit wary of the TransferGenomeEvent
I've put more details about this and more in the review for
Terasology/EdibleFlora#5
| if (!isInLastStage(bushComponent) | ||
| // allow negative growth from the last stage | ||
| || stages < 0) { | ||
| bush.send(new AddGenomeRetention()); |
There was a problem hiding this comment.
This feels like a bit clunky and weird to be doing through events tbh. That being said, given the state of optional dependencies this possibly is the best way to do this.
| newBush.addOrSaveComponent(bushComponent); | ||
|
|
||
| if (stage.getValue().maxTime > 0 && stage.getValue().minTime > 0) { | ||
| resetDelay(newBush, | ||
| stage.getValue().minTime, | ||
| stage.getValue().maxTime); | ||
| } | ||
|
|
||
| bush.send(new TransferGenomeEvent(newBush)); |
There was a problem hiding this comment.
This event by contrast seems a bit weird than that there should be a better way to do it.
3 tasks
e-aakash
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added genome related events to be handled by the GenomeAuthoritySystem if Genomes is enabled.
To-do before merging