Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify filling trait via genes and breeding capability #94

Merged
merged 8 commits into from
Aug 16, 2020

Conversation

vedant-shroff
Copy link
Contributor

@vedant-shroff vedant-shroff commented Jul 30, 2020

Contains :

This PR adds two features :

  1. Filling trait of seeds will now be affected by their filling gene. This PR contains the event which is then handled in EdibleFlora to change the filling value (Created FillingModifierSystem EdibleFlora#6)
  2. The Gene breeding is handled in the GenomeAuthoritySystem when the seedWorkstation is used to breed seeds.

This PR uses #93 as a base and therefore the diff will contain large parts of it, this should update once #93 is merged.

How to test :

  • Use the console command to get a seed, for example : give apple
  • Plant the seed on the ground to get a bush
  • Once the bush is fully grown, harvest it. This will attach genes to the seed and modify its filling value.
  • Use the setHunger <value> command to set your hunger to a measurable value, say 50
  • Eat the seed by right clicking while holding it and not looking at a block
  • Use the showHunger command to see your hunger value. The value can be tallied with the difference between the setHunger and current hunger and the Genes observed via the heldGenomeCheck command.
    Note : Make sure Created FillingModifierSystem EdibleFlora#6 is a part of your workspace to test this properly.

How to test breeding :

  • Use the console command to get two of the same seeds, for example : give apple 2
  • Plant the seeds on the ground to get two bushes
  • Once the bush is fully grown, harvest it. This will attach genes to the seeds and modify its filling value.
  • Use the console to give yourself a seedWorkstation give seedWorkstation
  • Place the workstation and breed the two seeds you got to get an output seed
  • Check its genes using the HeldGenomeCheck command.
  • Input seeds can be re harvested to compare the genes and confirm a proper breeding
    Note : Make sure added OnRecipeCrafted event BasicCrafting#3 is a part of your workspace to test this properly.

To-do :

  • Change vocabulary and conversion of vocabulary-->value for filling to form more realistic values for filling. Currently the values are ~ 5 to 15 for testing purposes.
  • The breeding PR in basicCrafting is yet to be made, once it is made it will be linked here and appropriate testing instructions will follow. (added OnRecipeCrafted event BasicCrafting#3)
  • Javadocs

Also, this probably finally addresses #82

@vedant-shroff vedant-shroff changed the base branch from develop to feature/genome August 11, 2020 16:34
@vedant-shroff vedant-shroff changed the base branch from feature/genome to develop August 11, 2020 16:35
Copy link
Member

@e-aakash e-aakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Javadocs has to be added and logging removed before merge

Can be merged after tested out with recipes in edible flora.

@e-aakash
Copy link
Member

Failed tests are after change in Module Testing Environment dependency update.

@e-aakash e-aakash merged commit a3e4934 into Terasology:develop Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants