Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assigning to the reactive Select.value doesn't post a Changed message #3611

Closed
rodrigogiraoserrao opened this issue Oct 30, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@rodrigogiraoserrao
Copy link
Contributor

The reactive Select.value can be assigned to and it will change the selection of the widget but it won't post a message Select.Changed.

@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Oct 30, 2023
@davep
Copy link
Contributor

davep commented Oct 30, 2023

Isn't this in keeping with a few other widgets within Textual, where setting its corresponding "value" won't result in a message, when user interaction would1?

Footnotes

  1. I tend to think any change should result in a message, but I'm just mentioning this as it feels like it's something that should be idiomatic to all widgets, one way or another.

@rodrigogiraoserrao
Copy link
Contributor Author

Maybe. I was looking at Input where assigning to its value will result in a message.

I have a very strong opinion in favour of all changes posting the relevant messages.

@TomJGooding
Copy link
Contributor

See also issue #3417 where this has come up before.

@rodrigogiraoserrao
Copy link
Contributor Author

Closed in favour of the issue linked above.

@github-actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

rodrigogiraoserrao added a commit that referenced this issue Oct 30, 2023
Related issues: #3611, #3612.
Related commit: 9c94113.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants