Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select.value isn't validated #3612

Closed
rodrigogiraoserrao opened this issue Oct 30, 2023 · 1 comment · Fixed by #3614
Closed

Select.value isn't validated #3612

rodrigogiraoserrao opened this issue Oct 30, 2023 · 1 comment · Fixed by #3614
Assignees
@rodrigogiraoserrao
Labels
bug Something isn't working

Comments

@rodrigogiraoserrao
Copy link
Contributor

As it stands, the reactive Select.value can be in an invalid state if you assign to it an option that the select doesn't know of.
Visually, the widget looks ok but the reactive will retain its bad value.
This could be fixed with a validator method, for example.
@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Oct 30, 2023
rodrigogiraoserrao added a commit that referenced this issue Oct 30, 2023
@rodrigogiraoserrao
Validate Select.value and revert 9c94113.
b8533ba 
Related issues: #3611, #3612.
Related commit: 9c94113.
@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Oct 30, 2023
Merged
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Nov 1, 2023
@github-actions GitHub Actions
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate Select.value and minor Select improvements. Textualize/textual
1 participant
@rodrigogiraoserrao