Create q_full_adder.py #6735
Create q_full_adder.py #6735
Conversation
This is for the #Hacktoberfest. This circuit is the quantum full adder. I saw that in the repo is the half adder so I decided to build the full adder to complete the set of adders. I hope that this is enough to be consider a contribution. Best, Kevin
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
quantum/q_full_adder.py
Outdated
| from qiskit import QuantumCircuit, QuantumRegister, ClassicalRegister, execute, Aer | ||
| import numpy as np | ||
|
|
||
| def q_full_adder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file quantum/q_full_adder.py, please provide doctest for the function q_full_adder
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
quantum/q_full_adder.py
Outdated
| from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | ||
|
|
||
|
|
||
| def q_full_adder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file quantum/q_full_adder.py, please provide doctest for the function q_full_adder
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
quantum/q_full_adder.py
Outdated
| from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | ||
|
|
||
|
|
||
| def q_full_adder( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file quantum/q_full_adder.py, please provide doctest for the function q_full_adder
algorithms-keeper
bot
removed
the
require tests
for more information, see https://pre-commit.ci
|
Dear @cclauss, |
| >>> quantum_full_adder(0,0,1) | ||
| {'01': 1000} | ||
| >>> quantum_full_adder(1,0,1) | ||
| {'10': 1000} |
There was a problem hiding this comment.
Please add some tests that fail... Negative numbers, floating point numbers, letters, etc.
algorithms-keeper
bot
added
awaiting changes
algorithms-keeper
bot
added
awaiting reviews
for more information, see https://pre-commit.ci
| from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute | ||
|
|
||
| from qiskit import QuantumCircuit, QuantumRegister, ClassicalRegister, execute, Aer | ||
| import math |
There was a problem hiding this comment.
Kinda cool how pre-commit fixes all this stuff… trailing whitespace, unsorted imports, single quotes, etc.
algorithms-keeper
bot
removed
the
awaiting reviews
This is for the #Hacktoberfest.
This circuit is the quantum full adder. I saw that in the repo is the half adder so I decided to build the full adder to complete the set of adders. I hope that this is enough to be consider a contribution. Best,
Kevin
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.