Remove Admin Authentication settings (#75)

* Remove admin auth settings * Remove leftover Admin Authentication stuff * Remove leftover scss file
ThePalaceProject · Mar 1, 2023 · f1b5d0f · f1b5d0f
1 parent 75b99a5
commit f1b5d0f
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 201 deletions.
diff --git a/src/__tests__/actions-test.ts b/src/__tests__/actions-test.ts
@@ -702,60 +702,6 @@ describe("actions", () => {
     });
   });
 
-  describe("fetchAdminAuthServices", () => {
-    it("dispatches request, load, and success", async () => {
-      const dispatch = stub();
-      const adminAuthServicesData = "adminAuthServices";
-      fetcher.testData = {
-        ok: true,
-        status: 200,
-        json: () =>
-          new Promise<any>((resolve, reject) => {
-            resolve(adminAuthServicesData);
-          }),
-      };
-      fetcher.resolve = true;
-
-      const data = await actions.fetchAdminAuthServices()(dispatch);
-      expect(dispatch.callCount).to.equal(3);
-      expect(dispatch.args[0][0].type).to.equal(
-        `${ActionCreator.ADMIN_AUTH_SERVICES}_${ActionCreator.REQUEST}`
-      );
-      expect(dispatch.args[1][0].type).to.equal(
-        `${ActionCreator.ADMIN_AUTH_SERVICES}_${ActionCreator.SUCCESS}`
-      );
-      expect(dispatch.args[2][0].type).to.equal(
-        `${ActionCreator.ADMIN_AUTH_SERVICES}_${ActionCreator.LOAD}`
-      );
-      expect(data).to.deep.equal(adminAuthServicesData);
-    });
-  });
-
-  describe("editAdminAuthService", () => {
-    it("dispatches request and success", async () => {
-      const editAdminAuthServiceUrl = "/admin/admin_auth_services";
-      const dispatch = stub();
-      const formData = new (window as any).FormData();
-      formData.append("name", "new name");
-
-      fetchMock.mock(editAdminAuthServiceUrl, "server response");
-      const fetchArgs = fetchMock.calls();
-
-      await actions.editAdminAuthService(formData)(dispatch);
-      expect(dispatch.callCount).to.equal(3);
-      expect(dispatch.args[0][0].type).to.equal(
-        `${ActionCreator.EDIT_ADMIN_AUTH_SERVICE}_${ActionCreator.REQUEST}`
-      );
-      expect(dispatch.args[1][0].type).to.equal(
-        `${ActionCreator.EDIT_ADMIN_AUTH_SERVICE}_${ActionCreator.SUCCESS}`
-      );
-      expect(fetchMock.called()).to.equal(true);
-      expect(fetchArgs[0][0]).to.equal(editAdminAuthServiceUrl);
-      expect(fetchArgs[0][1].method).to.equal("POST");
-      expect(fetchArgs[0][1].body).to.equal(formData);
-    });
-  });
-
   describe("fetchIndividualAdmins", () => {
     it("dispatches request, load, and success", async () => {
       const dispatch = stub();

diff --git a/src/actions.ts b/src/actions.ts
@@ -8,7 +8,6 @@ import {
   StatsData,
   LibrariesData,
   CollectionsData,
-  AdminAuthServicesData,
   IndividualAdminsData,
   PatronAuthServicesData,
   SitewideSettingsData,
@@ -75,9 +74,6 @@ export default class ActionCreator extends BaseActionCreator {
   static readonly COLLECTIONS = "COLLECTIONS";
   static readonly EDIT_COLLECTION = "EDIT_COLLECTION";
   static readonly DELETE_COLLECTION = "DELETE_COLLECTION";
-  static readonly ADMIN_AUTH_SERVICES = "ADMIN_AUTH_SERVICES";
-  static readonly EDIT_ADMIN_AUTH_SERVICE = "EDIT_ADMIN_AUTH_SERVICE";
-  static readonly DELETE_ADMIN_AUTH_SERVICE = "DELETE_ADMIN_AUTH_SERVICE";
   static readonly INDIVIDUAL_ADMINS = "INDIVIDUAL_ADMINS";
   static readonly EDIT_INDIVIDUAL_ADMIN = "EDIT_INDIVIDUAL_ADMIN";
   static readonly DELETE_INDIVIDUAL_ADMIN = "DELETE_INDIVIDUAL_ADMIN";
@@ -515,31 +511,6 @@ export default class ActionCreator extends BaseActionCreator {
     ).bind(this);
   }
 
-  fetchAdminAuthServices() {
-    const url = "/admin/admin_auth_services";
-    return this.fetchJSON<AdminAuthServicesData>(
-      ActionCreator.ADMIN_AUTH_SERVICES,
-      url
-    ).bind(this);
-  }
-
-  editAdminAuthService(data: FormData) {
-    const url = "/admin/admin_auth_services";
-    return this.postForm(ActionCreator.EDIT_ADMIN_AUTH_SERVICE, url, data).bind(
-      this
-    );
-  }
-
-  deleteAdminAuthService(identifier: string | number) {
-    const url = "/admin/admin_auth_service/" + identifier;
-    return this.postForm(
-      ActionCreator.DELETE_ADMIN_AUTH_SERVICE,
-      url,
-      null,
-      "DELETE"
-    ).bind(this);
-  }
-
   fetchIndividualAdmins() {
     const url = "/admin/individual_admins";
     return this.fetchJSON<IndividualAdminsData>(

diff --git a/src/components/AdminAuthServices.tsx b/src/components/AdminAuthServices.tsx
diff --git a/src/components/ConfigTabContainer.tsx b/src/components/ConfigTabContainer.tsx
@@ -2,7 +2,6 @@ import * as React from "react";
 import * as PropTypes from "prop-types";
 import Libraries from "./Libraries";
 import Collections from "./Collections";
-import AdminAuthServices from "./AdminAuthServices";
 import IndividualAdmins from "./IndividualAdmins";
 import PatronAuthServices from "./PatronAuthServices";
 import SitewideAnnouncements from "./SitewideAnnouncements";
@@ -47,7 +46,6 @@ export default class ConfigTabContainer extends TabContainer<
     libraries: Libraries,
     individualAdmins: IndividualAdmins,
     collections: Collections,
-    adminAuth: AdminAuthServices,
     patronAuth: PatronAuthServices,
     sitewideSettings: SitewideSettings,
     logging: LoggingServices,
@@ -65,7 +63,6 @@ export default class ConfigTabContainer extends TabContainer<
   SYSTEM_ADMIN_TABS = Object.keys(this.COMPONENT_CLASSES);
 
   DISPLAY_NAMES = {
-    adminAuth: "Admin Authentication",
     individualAdmins: "Admins",
     patronAuth: "Patron Authentication",
     sitewideAnnouncements: "Sitewide Announcements",

diff --git a/src/components/__tests__/ConfigTabContainer-test.tsx b/src/components/__tests__/ConfigTabContainer-test.tsx
@@ -8,7 +8,6 @@ import buildStore from "../../store";
 import ConfigTabContainer from "../ConfigTabContainer";
 import Libraries from "../Libraries";
 import Collections from "../Collections";
-import AdminAuthServices from "../AdminAuthServices";
 import IndividualAdmins from "../IndividualAdmins";
 import PatronAuthServices from "../PatronAuthServices";
 import SitewideSettings from "../SitewideSettings";
@@ -56,7 +55,6 @@ describe("ConfigTabContainer", () => {
       expect(linkTexts).to.contain("Libraries");
       expect(linkTexts).to.contain("Admins");
       expect(linkTexts).to.contain("Collections");
-      expect(linkTexts).to.contain("Admin Authentication");
       expect(linkTexts).to.contain("Patron Authentication");
       expect(linkTexts).to.contain("Sitewide Settings");
       expect(linkTexts).to.contain("Metadata");
@@ -69,7 +67,6 @@ describe("ConfigTabContainer", () => {
         Libraries,
         IndividualAdmins,
         Collections,
-        AdminAuthServices,
         PatronAuthServices,
         SitewideSettings,
         MetadataServices,
@@ -123,7 +120,6 @@ describe("ConfigTabContainer", () => {
       expect(linkTexts).to.contain("Admins");
       expect(linkTexts).not.to.contain("Analytics");
       expect(linkTexts).not.to.contain("Collections");
-      expect(linkTexts).not.to.contain("Admin Authentication");
       expect(linkTexts).not.to.contain("Patron Authentication");
       expect(linkTexts).not.to.contain("Sitewide Settings");
       expect(linkTexts).not.to.contain("Metadata");
@@ -141,7 +137,6 @@ describe("ConfigTabContainer", () => {
 
       const hiddenComponentClasses = [
         Collections,
-        AdminAuthServices,
         PatronAuthServices,
         SitewideSettings,
         MetadataServices,
@@ -195,7 +190,6 @@ describe("ConfigTabContainer", () => {
       const hiddenComponentClasses = [
         Collections,
         IndividualAdmins,
-        AdminAuthServices,
         PatronAuthServices,
         SitewideSettings,
         MetadataServices,

diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -293,12 +293,6 @@ export interface PathFor {
   (collectionUrl: string, bookUrl: string, tab?: string): string;
 }
 
-export interface AdminAuthServiceData extends ServiceData {}
-
-export interface AdminAuthServicesData extends ServicesData {
-  admin_auth_services: AdminAuthServiceData[];
-}
-
 export interface AdminRoleData {
   library?: string;
   role: string;

diff --git a/src/reducers/adminAuthServices.ts b/src/reducers/adminAuthServices.ts
diff --git a/src/reducers/index.ts b/src/reducers/index.ts
@@ -10,7 +10,6 @@ import stats, { StatsState } from "./stats";
 import diagnostics from "./diagnostics";
 import libraries from "./libraries";
 import collections from "./collections";
-import adminAuthServices from "./adminAuthServices";
 import individualAdmins from "./individualAdmins";
 import patronAuthServices from "./patronAuthServices";
 import sitewideAnnouncements from "./sitewideAnnouncements";
@@ -51,7 +50,6 @@ import patronManager from "./managePatrons";
 import {
   LibrariesData,
   CollectionsData,
-  AdminAuthServicesData,
   IndividualAdminsData,
   PatronAuthServicesData,
   SitewideAnnouncementsData,
@@ -87,7 +85,6 @@ export interface State {
   diagnostics: FetchEditState<DiagnosticsData>;
   libraries: FetchEditState<LibrariesData>;
   collections: FetchEditState<CollectionsData>;
-  adminAuthServices: FetchEditState<AdminAuthServicesData>;
   individualAdmins: FetchEditState<IndividualAdminsData>;
   patronAuthServices: FetchEditState<PatronAuthServicesData>;
   sitewideAnnouncements: FetchEditState<SitewideAnnouncementsData>;
@@ -134,7 +131,6 @@ export default combineReducers<State>({
   diagnostics,
   libraries,
   collections,
-  adminAuthServices,
   individualAdmins,
   patronAuthServices,
   sitewideAnnouncements,

diff --git a/src/stylesheets/admin_auth_service_edit_form.scss b/src/stylesheets/admin_auth_service_edit_form.scss
diff --git a/src/stylesheets/app.scss b/src/stylesheets/app.scss
@@ -10,7 +10,6 @@ $fontfamily: 'Open Sans', sans-serif;
 @import "colors";
 @import "global";
 
-@import "admin_auth_service_edit_form";
 @import "advanced_search";
 @import "announcements";
 @import "badge";