Remove Admin Authentication settings #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonathangreen @tdilauro @ray-lee I don't have access rights to assign people to PR so think of this as an PR review request :) |
io7m
approved these changes
Feb 14, 2023
2 tasks
tdilauro
requested changes
Feb 17, 2023
| @@ -10,7 +10,6 @@ $fontfamily: 'Open Sans', sans-serif; | |||
| @import "colors"; | |||
| @import "global"; | |||
|
|
|||
| @import "admin_auth_service_edit_form"; | |||
There was a problem hiding this comment.
It doesn't look like the corresponding admin_auth_service_edit_form.scss file has been removed. Do we need to keep that around for anything else?
There was a problem hiding this comment.
Good catch 👍 5764977
pcustic
requested review from
io7m and
tdilauro
and removed request for
io7m
|
@tdilauro I can't merge this so if you feel this is good to go can you please merge it? |
tdilauro
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Admin authentication provider settings in the System configuration page.
Motivation and Context
We are removing Google OAuth authentication provider in the CM and with that all the external admin authentication provider code. Since that means we are also removing endpoints for admin auth edit we need to remove these options in the admin UI.
Notion
CM PR
How Has This Been Tested?
Existing tests passed. I'll try to run the admin UI locally.
Checklist: