Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents can now be uploaded without specifying title via the REST API. #5

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

ahmdthr
Copy link

@ahmdthr ahmdthr commented Dec 4, 2023

Previously documents could not be uploaded if the title was not specified. Documents can now be uploaded without specifying title.

Resolves https://github.com/Thuenen-GeoNode-Development/Sprints/issues/16

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@ridoo
Copy link

ridoo commented Dec 18, 2023

@ahmdthr what is the status of this PR?

@ridoo
Copy link

ridoo commented Jan 8, 2024

@ahmdthr

  • remove draft
  • create upstream PR

@ridoo

  • test the PR

@ridoo
Copy link

ridoo commented Jan 25, 2024

@ahmdthr Is this PR still in draft?

@ahmdthr ahmdthr marked this pull request as ready for review February 14, 2024 14:20
@ridoo ridoo merged commit 1eeaf71 into thuenen_4.x Feb 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants