[PATCH-AVR] avr-rust/rust-legacy-fork#101 (D53106): topological sorting

TimNN · Oct 28, 2018 · dea8c37 · dea8c37
1 parent 71713c2
commit dea8c37
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/include/llvm/CodeGen/SelectionDAGNodes.h b/include/llvm/CodeGen/SelectionDAGNodes.h
@@ -836,6 +836,12 @@ class SDNode : public FoldingSetNode, public ilist_node<SDNode> {
                                    SmallVectorImpl<const SDNode *> &Worklist,
                                    unsigned int MaxSteps = 0,
                                    bool TopologicalPrune = false) {
+    // NOTE(TimNN): I'm not confident that the in-progress D53106 actually
+    //              handles the topological ordering correctly, so I'm disabling
+    //              this performance optimization until the upstream patch has
+    //              been accepted.
+    TopologicalPrune = false;
+
     SmallVector<const SDNode *, 8> DeferredNodes;
     if (Visited.count(N))
       return true;
@@ -867,6 +873,14 @@ class SDNode : public FoldingSetNode, public ilist_node<SDNode> {
       }
       for (const SDValue &OpV : M->op_values()) {
         SDNode *Op = OpV.getNode();
+        // If we are adding a glued node, its glued user should be considered a
+        // predecessor as well to prevent a node merge causing a non-immediate
+        // use of a glue operand. Walk down all unvisited glue users.
+        while (auto *GN = Op->getGluedUser()) {
+          if ((GN == M) || Visited.count(GN))
+            break;
+          Op = GN;
+        }
         if (Visited.insert(Op).second)
           Worklist.push_back(Op);
         if (Op == N)