Check for productcode even if extension doesn't match

[Trenly]

• Closes Check for ProductCode if url does not end with .msi #150
  @OfficialEsco This should do what you wanted, but I will warn you that if the installer type is MSI or WIX and the file that is downloaded is not truly an MSI file then it will likely error out. The more intelligent that we try to make things, the bigger the chance that incorrect input will cause things to go 💥

[OfficialEsco]

weeeell, if its not .msi @vedantmgoyal2009 got a problem

it did however fail to identify it as wix 🤔

[Trenly]

@OfficialEsco Also think I fixed this one; Some light testing allowed it to detect the ProductCode using https://sourceforge.net/projects/scidavis/files/SciDAVis/2/2.7/scidavis.2.7-win-dist.msi/download as the download link in quick update mode. Doesn't work in Full Update mode because the detection happens before InstallerType is specified, but will look to fix that separately since it requires a bit more refactoring.

[OfficialEsco]

Oh yeah as i said

it did however fail to identify it as wix 🤔

Step to replicate

PS .\Tools\YamlCreate.ps1 -AutoUpgrade -SkipPRCheck -PackageIdentifier Microsoft.RemoteDesktopClient -PackageVersion 1.2.2688.0


Found Existing Version: 1.2.2688.0

Updating Manifest Information. This may take a while...

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.locale.en-US.yaml

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.installer.yaml

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.yaml
Manifest validation succeeded.


Do you want to submit your PR now?
  [Y] Yes
  [N] No

Enter Choice (default is 'Y'): n

or

PS .\Tools\YamlCreate.ps1 -mode 2 -SkipPRCheck -PackageIdentifier Microsoft.RemoteDesktopClient -PackageVersion 1.2.2688.0

Found Existing Version: 1.2.2688.0
Installer Entry #1:

        Architecture: x64
        InstallerType: msi
        Scope: user


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX
Downloading Installer. . .
Installer Downloaded!
Processing installer data. . .
Installer updated!

Installer Entry #2:

        Architecture: x64
        InstallerType: msi
        Scope: machine


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX
Installer Entry #3:

        Architecture: x86
        InstallerType: msi
        Scope: user


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX
Installer Entry #4:

        Architecture: x86
        InstallerType: msi
        Scope: machine


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX
Installer Entry #5:

        Architecture: arm64
        InstallerType: msi
        Scope: user


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX
Installer Entry #6:

        Architecture: arm64
        InstallerType: msi
        Scope: machine


[Required] Enter the download url to the installer.
Url: https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RWQvmX

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.locale.en-US.yaml

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.installer.yaml

Yaml file created: C:\Users\Esco\GitHub\winget-pkgs\manifests\m\Microsoft\RemoteDesktopClient\1.2.2688.0\Microsoft.RemoteDesktopClient.yaml
Manifest validation succeeded.


Do you want to submit your PR now?
  [Y] Yes
  [N] No

Enter Choice (default is 'Y'): n

InstallerType remains msi

[OfficialEsco]

Late update but i have used this since the change and not had issues other than when i fked up + the no wix detection
But we probably need a safer method for bots