-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match WIX logic to wingetcreate #152
Conversation
Does this work with and solve the #151 error? |
It does work with #151 but it doesn't solve the issue of not being able to detect wix vs msi if the file itself does not end in There are multiple reasons for that -
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedieaston would you mind taking a look at this 🔥 code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh gosh, sorry for the delay. This looks great!
* Url checking (Trenly#148) * Prompt user to use direct URL * Formatting * Fix: PS7 Resource Delegation * Ignore github for url checking * Add messaging for User Experience * Fix bug where URI could contain invalid characters * Match WIX logic to wingetcreate (Trenly#152) * Fix: Don't retain SignatureSha256 between installers * Culture sorting (Trenly#157) * Set culture of current thread while running * Fix Null Value
@OfficialEsco @jedieaston
As I was working on 3.0, I found a way to extract most of the MSI database to an object in PowerShell. This allows for the same logic as microsoft/winget-create#220 and should more reliably detect WIX installers, even if the
CreatedBy
doesn't match one of our expected values. This PR backports that solution into the 2.0 script