-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support consul service meta data #592
Comments
code can be seen @ https://github.com/lucwillems/containerpilot/tree/issue_592 |
This all looks like good work. I'm inclined to take it. I'd like to see some testing results and list any known issues or backward incompatibilities. The changelog file should also be updated. If you open a PR we'll review it. |
i have a pre release binary build in my repository for downloading. i'll be offline from today for the next week but will come back next week. |
PR created. issues of quoted "keys" is related to JSON5 parsing of configuration, which doesn't allow unquoted key names with "-" |
@bahamat can we include this PR into the main tree and release this ? |
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <luc.willems@t-m-m.be>
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <luc.willems@t-m-m.be>
TritonDataCenter#592 TritonDataCenter#593 All credits and thanks to Luc Willems Co-authored-by: Luc Willems <luc.willems@t-m-m.be>
i'm working on support for service.meta data which was introduced in consul around 1.10 , see hashicorp/consul#4045
this includes upgrading the build stack and dependencies for consul and prometheus and upgrade to go 1.13
still work in progress because current go build are based on glide which is deprecated, but currently my local
build can run the make clean build test integration targets with no errors and meta tag added
to containerpilot.json configuration.
currently i have changed 15 files, so it's a kind of big. how do a approach the inclusion of the feature in the tree ?
see also #572 , current project owner/status is unclear and it has been idle for some years..
this could become a 3.9.0 as both consul and prometheus dependencies are upgraded to highest level
which glide can handle , prometheus is requires go mod for higher updates.
The text was updated successfully, but these errors were encountered: