Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service metadata to the agent service definition struct #4045

Closed
preetapan opened this issue Apr 18, 2018 · 1 comment
Closed

Add service metadata to the agent service definition struct #4045

preetapan opened this issue Apr 18, 2018 · 1 comment
Labels
type/bug Feature does not function as expected
Milestone
1.1.0

Comments

@preetapan
Copy link
Contributor

#3881 missed adding service metadata to

consul/agent/config/config.go

Line 317 in a67d27c

type ServiceDefinition struct {
, we will need to add it there to allow specifying service metadata in service files loaded by the agent
@preetapan preetapan added the type/bug Feature does not function as expected label Apr 18, 2018
@preetapan preetapan added this to the 1.1.0 milestone Apr 18, 2018
@preetapan preetapan mentioned this issue Apr 18, 2018
Closed
@kadaan
Copy link

kadaan commented Apr 18, 2018

Thanks for adding this. Will be super helpful to have!

pierresouchay added a commit to pierresouchay/consul that referenced this issue Apr 18, 2018
@pierresouchay
[BUGFIX] Added Service Meta support in configuration files
d2ab3de 
Fixes hashicorp#4045

Was not added by mistake in hashicorp#3881
@pierresouchay pierresouchay mentioned this issue Apr 18, 2018
Merged
@lucwillems lucwillems mentioned this issue Jun 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Feature does not function as expected
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@preetapan @kadaan